Re: [PATCH v2] hw/nvme: fix unintentional integer overflow in shift
Philippe Mathieu-Daudé <[email protected]>
| Newsgroups | gmane.comp.emulators.qemu.stable,gmane.comp.emulators.qemu,gmane.comp.emulators.qemu.block |
|---|---|
| Message-ID | <[email protected]> |
On 28/7/26 11:42, Klaus Jensen wrote: > From: Klaus Jensen <[email protected]> > > Fix potentially overflowing shift operation. > > Cc: [email protected] > Suggested-by: Peter Maydell <[email protected]> > Suggested-by: Philippe Mathieu-Daudé <[email protected]> > Resolves: Coverity CID 1663674 > Fixes: ec917cd49918 ("hw/nvme: fix FDP set FDP events") > Signed-off-by: Klaus Jensen <[email protected]> > --- > Changes in v2: > - use deposit64 > - Link to v1: https://lore.kernel.org/qemu-devel/[email protected] > --- > hw/nvme/ctrl.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Please include "qemu/bitops.h" when applying (it is indirectly included but we rather explicit includes otherwise refactoring unrelated headers might break here), otherwise: Reviewed-by: Philippe Mathieu-Daudé <[email protected]>