Re: [PATCH v2] hw/nvme: fix unintentional integer overflow in shift

Klaus Jensen <[email protected]>
Newsgroups gmane.comp.emulators.qemu.block,gmane.comp.emulators.qemu,gmane.comp.emulators.qemu.stable
Message-ID <[email protected]>
On Jul 28 18:15, Philippe Mathieu-Daudé wrote:
> On 28/7/26 11:42, Klaus Jensen wrote:
> > From: Klaus Jensen <[email protected]>
> > 
> > Fix potentially overflowing shift operation.
> > 
> > Cc: [email protected]
> > Suggested-by: Peter Maydell <[email protected]>
> > Suggested-by: Philippe Mathieu-Daudé <[email protected]>
> > Resolves: Coverity CID 1663674
> > Fixes: ec917cd49918 ("hw/nvme: fix FDP set FDP events")
> > Signed-off-by: Klaus Jensen <[email protected]>
> > ---
> > Changes in v2:
> > - use deposit64
> > - Link to v1: https://lore.kernel.org/qemu-devel/[email protected]
> > ---
> >   hw/nvme/ctrl.c | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> Please include "qemu/bitops.h" when applying (it is indirectly
> included but we rather explicit includes otherwise refactoring
> unrelated headers might break here), otherwise:
> 

Gotcha.

> Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
>
signature.asc (application/pgp-signature, 488 B)
-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEUigzqnXi3OaiR2bATeGvMW1PDekFAmpo1oQACgkQTeGvMW1P
DemilggAgpxDlIMEof7nunn3L+AAdqb/3LBO8EL9Pzo0yNF7fO8NOnKpsB2BSTDM
MY41aAhtDRQl0Ra6hRA5qrml+3cfA+crYA+Bazhr1XWnV24P43xbKKJmFc4898sF
IDovtDGii8w6WUFzaJ+Hm8pfHF/qPsPCcQW6GiHpEsjKEDZ7VXT65wAw7oJhCF50
f8Wp9r6JSL9xMHD9LYvkWxRxI2tpSXEswwrWFWxDgjVcWV2mIwOVSFdFQgFkKyXR
4bR+nfAz1McFEIJHEEhr0kCFaNUw55X9f2YWgOZBEpBWdz/rKLJeKwTXlYlKKyiI
PuNZRmtE+vBTnEHbu6KxXYJAfLNqdg==
=yUZL
-----END PGP SIGNATURE-----
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.