Re: [PATCH 3/5] migration/multifd: Replace assert() with error_setg() in recv paths

On Tue, Jul 28, 2026 at 05:59:30PM -0300, Fabiano Rosas wrote:
> Peter Xu <[email protected]> writes:
> 
> > On Tue, Jul 28, 2026 at 04:51:07PM -0300, Fabiano Rosas wrote:
> >> Peter Xu <[email protected]> writes:
> >> 
> >> > QPL and UADK multifd backends use assert() to validate wire-controlled
> >> > fields like per-page compressed lengths and packet size consistency.  These
> >> > asserts will stop working with released version of binaries, so may stop
> >> > working.
> >> 
> >> This is not true, asserts are always on. Same for the similar comment in
> >> the previous patch commit message.
> >
> > Shall I perhaps replace this to "when compiled with -DNDEBUG"?
> >
> 
> It's not allowed as per osdep.h:
> 
> #ifdef NDEBUG
> #error building with NDEBUG is not supported
> #endif

I shouldn't have sent v2.. I'll wait for a few days for sending v3.

-- 
Peter Xu