[PATCH v2 22/50] helper-to-tcg: Introduce PrepareForTcgPass
Anton Johansson via qemu development <[email protected]>
| Newsgroups | gmane.comp.emulators.qemu |
|---|---|
| Message-ID | <[email protected]> |
Adds a new pass over the LLVM module which runs post-optimization with the end-goal of: * Culling functions which aren't worth translating; * Canonicalizing the IR to something closer to TCG, and; * Extracting information which may be useful in the backend pass. The bulk of IR transformations occur in the canonicalization phase, with a handful occuring later in the packend. This commits sets up a new LLVM pass over the IR module and runs it from the pipeline. Signed-off-by: Anton Johansson <[email protected]> --- .../helper-to-tcg/include/CmdLineOptions.hpp | 2 ++ .../include/PrepareForTcgPass.hpp | 27 +++++++++++++++++++ subprojects/helper-to-tcg/meson.build | 1 + subprojects/helper-to-tcg/src/Pipeline.cpp | 24 +++++++++++++++++ .../PrepareForTcgPass/PrepareForTcgPass.cpp | 25 +++++++++++++++++ 5 files changed, 79 insertions(+) create mode 100644 subprojects/helper-to-tcg/include/PrepareForTcgPass.hpp create mode 100644 subprojects/helper-to-tcg/src/PrepareForTcgPass/PrepareForTcgPass.cpp diff --git a/subprojects/helper-to-tcg/include/CmdLineOptions.hpp b/subprojects/helper-to-tcg/include/CmdLineOptions.hpp index ca1cb59835..bfdd3ebe41 100644 --- a/subprojects/helper-to-tcg/include/CmdLineOptions.hpp +++ b/subprojects/helper-to-tcg/include/CmdLineOptions.hpp @@ -23,3 +23,5 @@ extern llvm::cl::list<std::string> InputFiles; // Options for PrepareForOptPass extern llvm::cl::opt<bool> TranslateAllHelpers; +// Options for PrepareForTcgPass +extern llvm::cl::opt<std::string> TcgGlobalMappingsName; diff --git a/subprojects/helper-to-tcg/include/PrepareForTcgPass.hpp b/subprojects/helper-to-tcg/include/PrepareForTcgPass.hpp new file mode 100644 index 0000000000..90bc9402cb --- /dev/null +++ b/subprojects/helper-to-tcg/include/PrepareForTcgPass.hpp @@ -0,0 +1,27 @@ +// +// Copyright(c) 2026 rev.ng Labs Srl. All Rights Reserved. +// +// This program is free software; you can redistribute it and/or modify +// it under the terms of the GNU General Public License as published by +// the Free Software Foundation; either version 2 of the License, or +// (at your option) any later version. +// +// This program is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. +// +// You should have received a copy of the GNU General Public License +// along with this program; if not, see <http://www.gnu.org/licenses/>. +// + +#pragma once + +#include <llvm/IR/PassManager.h> + +class PrepareForTcgPass : public llvm::PassInfoMixin<PrepareForTcgPass> { +public: + PrepareForTcgPass() {} + llvm::PreservedAnalyses run(llvm::Module &M, + llvm::ModuleAnalysisManager &MAM); +}; diff --git a/subprojects/helper-to-tcg/meson.build b/subprojects/helper-to-tcg/meson.build index b3a3de6297..c2926652f3 100644 --- a/subprojects/helper-to-tcg/meson.build +++ b/subprojects/helper-to-tcg/meson.build @@ -44,6 +44,7 @@ sources = [ 'src/Pipeline.cpp', 'src/PrepareForOptPass/PrepareForOptPass.cpp', 'src/PseudoInst.cpp', + 'src/PrepareForTcgPass/PrepareForTcgPass.cpp', ] clang = bindir / 'clang' diff --git a/subprojects/helper-to-tcg/src/Pipeline.cpp b/subprojects/helper-to-tcg/src/Pipeline.cpp index 571276de24..6058718a9c 100644 --- a/subprojects/helper-to-tcg/src/Pipeline.cpp +++ b/subprojects/helper-to-tcg/src/Pipeline.cpp @@ -18,6 +18,7 @@ #include "CmdLineOptions.hpp" #include "LlvmCompat.hpp" #include "PrepareForOptPass.hpp" +#include "PrepareForTcgPass.hpp" #if LLVM_VERSION_MAJOR == 15 #include <llvm/ADT/Triple.h> @@ -32,6 +33,7 @@ #include <llvm/IR/LLVMContext.h> #include <llvm/IR/Module.h> #include <llvm/IR/PassManager.h> +#include <llvm/IR/Verifier.h> #include <llvm/IRReader/IRReader.h> #include <llvm/InitializePasses.h> #include <llvm/Linker/Linker.h> @@ -43,6 +45,7 @@ #include <llvm/Support/SourceMgr.h> #include <llvm/Support/TargetSelect.h> #include <llvm/Target/TargetMachine.h> +#include <llvm/Transforms/Scalar/DCE.h> #include <llvm/Transforms/Scalar/SROA.h> #define DEBUG_TYPE "pipeline" @@ -70,6 +73,13 @@ cl::opt<bool> TranslateAllHelpers( "translate-all-helpers", cl::init(false), cl::desc("Translate all functions starting with helper_*"), cl::cat(Cat)); +// Options for PrepareForTcgPass +cl::opt<std::string> TcgGlobalMappingsName( + "tcg-global-mappings", + cl::desc("<Name of global cpu_mappings[] used for mapping accesses" + "into a struct to TCG globals>"), + cl::Required, cl::cat(Cat)); + // Define a TargetTransformInfo (TTI) subclass, this allows for overriding // common per-llvm-target information expected by other LLVM passes, such // as the width of the largest scalar/vector registers. Needed for consistent @@ -214,5 +224,19 @@ int main(int argc, char **argv) { MPM.addPass( PB.buildModuleOptimizationPipeline(compat::OptimizationLevel::Oz, {})); + // + // Next, we run our final transformations, including removing phis and our + // own instruction combining that prioritizes instructions that map more + // easily to TCG. + // + + MPM.addPass(PrepareForTcgPass()); + MPM.addPass(VerifierPass()); + { + FunctionPassManager FPM; + FPM.addPass(DCEPass()); + MPM.addPass(createModuleToFunctionPassAdaptor(std::move(FPM))); + } + return 0; } diff --git a/subprojects/helper-to-tcg/src/PrepareForTcgPass/PrepareForTcgPass.cpp b/subprojects/helper-to-tcg/src/PrepareForTcgPass/PrepareForTcgPass.cpp new file mode 100644 index 0000000000..cea6573e41 --- /dev/null +++ b/subprojects/helper-to-tcg/src/PrepareForTcgPass/PrepareForTcgPass.cpp @@ -0,0 +1,25 @@ +// +// Copyright(c) 2026 rev.ng Labs Srl. All Rights Reserved. +// +// This program is free software; you can redistribute it and/or modify +// it under the terms of the GNU General Public License as published by +// the Free Software Foundation; either version 2 of the License, or +// (at your option) any later version. +// +// This program is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. +// +// You should have received a copy of the GNU General Public License +// along with this program; if not, see <http://www.gnu.org/licenses/>. +// + +#include "PrepareForTcgPass.hpp" + +using namespace llvm; + +PreservedAnalyses PrepareForTcgPass::run(Module &M, ModuleAnalysisManager &MAM) +{ + return PreservedAnalyses::none(); +} -- 2.52.0