Re: [PATCH 4/4] migration: Remove duplicate vmstate macros

On 30.07.26 01:52, Fabiano Rosas wrote:
> -#define VMSTATE_STRUCT_VARRAY_INT32(_field, _state, _field_num, _version, _vmsd, _type) { \
> -    .name       = (stringify(_field)),                               \
> -    .num_offset = vmstate_field_offset(_state, _field_num, int32_t), \

Hmm, this int32_t should be dropped in earlier commit.. It doesn't break
compilation because VMSTATE_STRUCT_VARRAY_INT32. Suggest to drop it
completely in patch 01, together with VMSTATE_ARRAY_INT32_UNSAFE.

(interesting, do we have more unused macros?)

> -    .version_id = (_version),                                        \
> -    .vmsd       = &(_vmsd),                                          \
> -    .size       = sizeof(_type),                                     \
> -    .flags      = VMS_STRUCT | VMS_VARRAY,                           \
> -    .offset     = vmstate_offset_varray(_state, _field, _type),      \
> -}
> -


-- 
Best regards,
Vladimir