Re: [PATCH v2 01/50] accel/tcg: Add bitreverse and funnel-shift runtime helper functions
Richard Henderson <[email protected]>
| Newsgroups | gmane.comp.emulators.qemu |
|---|---|
| Message-ID | <[email protected]> |
On 7/29/26 20:09, Anton Johansson via qemu development wrote:
> +uint64_t HELPER(fshl_i64)(uint64_t a, uint64_t b, uint64_t c)
> +{
> + Int128 d = int128_make128(b, a);
> + Int128 shift = int128_lshift(d, c);
> + return int128_gethi(shift);
> +}
The existing similar opcode is extract2, performing a constant right double-word shift.
I'm open to adding a variable version, and adding left-shift, but we shouldn't have two
names for the same operation.
Plus Phil's comment about not doing two things in the same patch.
r~