Re: [PATCH v3 0/2] hw/nvme: support online resize

On Aug  3 10:30, Alexander Mikhalitsyn wrote:
> From: Alexander Mikhalitsyn <[email protected]>
> 
> Dear friends,
> 
> This patchset is aimed to support online resize for NVMe emulated
> device. My approach is simple - I just implement (BlockDevOps *)->resize_cb()
> callback and ensure that AER notification is fired to all controllers using
> a namespace that is being resized.
> 
> Testing.
> 
> I manually validated this with Debian 13 VM (a resized disk was a root disk) and
> Windows Server 2022 (a resized disk was a secondary one).
> 
> Git tree:
> https://gitlab.com/mihalicyn/qemu/-/commits/nvme-resize
> 
> Changelog for version 3:
> - rebased
> 
> Changelog for version 2:
> - checkpatch fixes
> - rebased
> - CI is green (https://gitlab.com/mihalicyn/qemu/-/pipelines/2602102750)
> 
> Kind regards,
> Alex
> 
> Alexander Mikhalitsyn (2):
>   hw/nvme: initialize ns->subsys for n->namespace
>   hw/nvme: support online resize
> 
>  hw/nvme/ctrl.c | 10 ++++++++
>  hw/nvme/ns.c   | 68 +++++++++++++++++++++++++++++++++++++++++++++++++-
>  hw/nvme/nvme.h |  2 ++
>  3 files changed, 79 insertions(+), 1 deletion(-)
> 
> -- 
> 2.47.3
> 
> 

LGTM.

Reviewed-by: Klaus Jensen <[email protected]>

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEUigzqnXi3OaiR2bATeGvMW1PDekFAmpwmrEACgkQTeGvMW1P
Dem5ZggAmfMv7VyPoNEQMQkgR7fI2tIi6zCaNqlCBVvC3jzC6k7rLIQ7D+DyjHpb
HP6IBq8zIfa94Y1e+DF1uwgYv4lN0EIVhX3q2e6nOtn3yYJasAaFVS2yEXOMaBOn
vEpL17ToFrzqb3dBQ2JnXNTjBl8e8hauDeFnJUSmGJBWgwCGN78EKNX/Bncnm9+4
etrEKPb8Z2KGJr01zzn/RRKn14paAmW3YWkHzTh60aZLmaQPjHAfvEJYRBSUF6IX
rPgMjtY14v/+gxS0yXFX7KRdYN3LHb8JJJg4rDnoAP7FQt2n1hgR9WtymTOUONe9
3qRzy06jNgFbJI0cWiL5PTI2UCQdyA==
=wet8
-----END PGP SIGNATURE-----