Re: [PATCH RFC 04/15] net/vhost-user: add memory isolation

On Mon, Jul 27, 2026 at 11:48 AM Stefan Hajnoczi <[email protected]> wrote:
>
>
> This is dead code (hence G_GNUC_UNUSED) and is harder to review because
> we don't know how it will be used until later in the patch series. I
> guess vhost_user_init() and net_passt_vhost_user_init() will gain a
> memory_isolation argument in a future patch.
>
> Linear reviews of the patch series are easiest for reviewers. Please
> reorder this so that vhost_user_init() and net_pass_vhost_user_init()
> are changed first. You can hardcode the argument to false in those
> patches. This patch can be moved afterwards so that memory_isolation is
> never dead code.

Now fixed for the next rev.  This and the previous patch are swapped,
with hardcoded values of memory_isolation used until the property is added
to net.json.

On Mon, Aug 3, 2026 at 5:27 AM Hanna Czenczek <[email protected]> wrote:
>
>
> I have a gut feeling there ought to be a better way to add an option the
> only works for vhost-user, but maybe not. I certainly don’t have a
> constructive suggestions. :)
>
> (Apart from that, my only comments would be the QAPI “since” field
> missing, as Markus noted on the previous patch, and the patch ordering
> Stefan has noted.)
>
> Hanna
>

Added "Since 11.2" to both locations in net.json.