Re: [PATCH v8 0/7] igb: Implement Transmit Rate Limiting (TRL)
Akihiko Odaki <[email protected]>
| Newsgroups | gmane.comp.emulators.qemu |
|---|---|
| Message-ID | <[email protected]> |
On 2026/08/07 3:44, Josh Hilke wrote: > Which version will this be added to? 11.2 since 11.1 is about to be released. Context: the network device subsystem has been the "Odd Fixes" state for a decade (i.e., no one is paid to maintain it and don't have time to do much other than "throw the odd patch in"). Jason Wang used to make pull requests with network device patches (igb and others), but apparently he recently left Red Hat. Regards, Akihiko Odaki > > Regards, > Josh Hilke > > On Tue, Jun 30, 2026 at 12:52 AM Akihiko Odaki > <[email protected]> wrote: >> >> On 2026/06/30 3:11, Josh Hilke wrote: >>> Do I need to push a v9 to include your "Reviewed-by" tag? >> >> No. I think this series is ready to pull along with other network patches. >> >> Regards, >> Akihiko Odaki >> >>> >>> Thanks, >>> Josh >>> >>> On Wed, Jun 24, 2026 at 1:18 AM Akihiko Odaki >>> <[email protected]> wrote: >>>> >>>> On 2026/06/24 0:05, Josh Hilke wrote: >>>>> This is v8 of a patch series implementing the Transmit Rate Limiter (TRL) feature for >>>>> the Intel 82576 (igb) network device emulation in QEMU. >>>>> >>>>> v7: https://lists.gnu.org/archive/html/qemu-devel/2026-06/msg05440.html >>>>> >>>>> Changelog: >>>>> >>>>> v8: >>>>> - Fix extraneous whitespace modifications. >>>>> - Use muldiv64() in igb_trl_calculate_delay(). >>>>> - Fix comment for rate factor in igb_trl_calculate_delay().> >>>>> Signed-off-by: Josh Hilke <[email protected]> >>>> >>>> For the whole series: >>>> >>>> Reviewed-by: Akihiko Odaki <[email protected]> >>>> >>>> Regards, >>>> Akihiko Odaki >>>> >>>>> --- >>>>> Josh Hilke (7): >>>>> igb: Define TRL registers and core state >>>>> igb: Add VMState support for TRL state >>>>> igb: Implement TRL register write and configuration >>>>> igb: Refactor TX path to return processed byte count >>>>> igb: Implement TRL throttling and timer resumption >>>>> igb: Add QTest for Transmit Rate Limiter register multiplexing >>>>> igb: Add QTest for Transmit Rate Limiter traffic throttling >>>>> >>>>> hw/net/igb.c | 43 +++++++++++ >>>>> hw/net/igb_common.h | 1 + >>>>> hw/net/igb_core.c | 142 ++++++++++++++++++++++++++++++++-- >>>>> hw/net/igb_core.h | 12 +++ >>>>> hw/net/igb_regs.h | 5 ++ >>>>> tests/qtest/igb-test.c | 206 +++++++++++++++++++++++++++++++++++++++++++++++++ >>>>> 6 files changed, 404 insertions(+), 5 deletions(-) >>>>> --- >>>>> base-commit: 98b060da3a4f92b2a994ead5b16a87e783baf77c >>>>> change-id: 20260608-igb-trl-19be198da6f2 >>>>> >>>>> Best regards, >>>> >>