Re: [PATCH] target/i386: Clear OF, SF, and AF for fcomi/fucomi

Good catch, sent as v2!

On Thu, Aug 6, 2026 at 6:28 PM Richard Henderson
<[email protected]> wrote:
>
> On 8/6/26 07:52, Simon Scherer wrote:
> > +    /* OF, SF, and AF are unconditionally cleared to 0 */
> > +    eflags = cpu_cc_compute_all(env) &
> > +                 ~(CC_O | CC_S | CC_Z | CC_A | CC_P | CC_C);
>
> There are only 6 flags, and you have cleared all of them.
> Which means you don't need to compute any of them, just
>
> -     CC_SRC = eflags | fcomi_ccval[ret + 1];
> +     CC_SRC = fcomi_ccval[ret + 1];
>
>
> r~