[PATCH RFC 0/1] an extensible SetUIInfo2 design
Chengyang Zhu <[email protected]>
| Newsgroups | gmane.comp.emulators.qemu |
|---|---|
| Message-ID | <[email protected]> |
Currently, the `SetUIInfo` method cannot set a refresh rate.
Simply adding a refresh_rate argument would break the method signature.
This RFC adds the `SetUIInfo2` method and `QemuUIInfoTypes` property.
* `SetUIInfo2` takes a dictionary,
allowing partial updates and adding more keys in the future.
* `QemuUIInfoTypes` exposes the schema of `SetUIInfo2`'s argument.
This patch is a proof-of-concept and it needs further discussion on:
* public API design (the name and the signature)
* partial update behavior (only updating the recognized fields)
* error handling (ignore the wrong keys or return an error?)
Test results:
* qemu:qtest-x86_64/dbus-display-test passed
* qemu:qtest-x86_64/dbus-vmstate-test passed
* qemu:qtest-x86_64/dbus-vnc-test SKIP
* manually created a virtual machine
and successfully set its refresh rate and resolution via `SetUIInfo2`
Chengyang Zhu (1):
ui/dbus: add extensible SetUIInfo2 method
ui/dbus-console.c | 56 ++++++++++++++++++++++++++++++++++++++++++++
ui/dbus-display1.xml | 17 ++++++++++++++
2 files changed, 73 insertions(+)
--
2.55.0