Re: [PATCH] linux-user: implement mount_setattr(2)

On 8/5/26 19:16, Matt Turner wrote:
> mount_setattr() was in the syscall tables but had no implementation, so
> guests always got -ENOSYS. systemd uses it when setting up per-unit
> credential mounts, which fails the affected units with EXIT_CREDENTIALS.
> 
> struct mount_attr is an extensible struct like open_how, so handle it the
> same way openat2() does: reject sizes smaller than the ver0 struct and
> require any unknown trailing bytes to be zero. All of its fields are
> 64-bit, and the MOUNT_ATTR_* and MS_* propagation values are identical on
> every target, so only the byte order needs fixing up.
> 
> Signed-off-by: Matt Turner <[email protected]>
> ---
>   linux-user/strace.list    |  3 +++
>   linux-user/syscall.c      | 44 +++++++++++++++++++++++++++++++++++++++
>   linux-user/syscall_defs.h | 13 ++++++++++++
>   3 files changed, 60 insertions(+)
Reviewed-by: Helge Deller <[email protected]>

I'll queue that patch (and the others) up for after qemu-v11.1 has been released.

Thanks!
Helge