Re: [PATCH v2 13/50] helper-to-tcg: PrepareForOptPass, demangle function names

On Thu, 30 Jul 2026 05:09:47 +0200
Anton Johansson <[email protected]> wrote:

> +        Index = DemangledName.find_last_of(':');
> +        if (Index != std::string::npos) {
> +            FunctionName = DemangledName.substr(Index + 1);
> +        }
> +        // Remove arguments
> +        Index = FunctionName.find_first_of('(');
> +        if (Index != std::string::npos) {
> +            FunctionName = FunctionName.substr(0, Index);
> +        }

LLVM provides a dedicated function to parse mangled
names: getFunctionBaseName. It's in LLVM, so new dependencies (I thought
was in clang).

The current code wouldn't handle `ns::function(ns::type)`.

Also, more in general: why are we setting the function name to the
name of the original C++ function name?
It's a feature worth documenting in the README along with its ratio.

Reviewed-by: Alessandro Di Federico <[email protected]>

-- 
Alessandro Di Federico
rev.ng Labs