Re: [PATCH] file-posix: fix zone write granularity assignment for zoned block devices
Damien Le Moal <[email protected]>
| Newsgroups | gmane.comp.emulators.qemu.block,gmane.comp.emulators.qemu |
|---|---|
| Organization | Western Digital Research |
| Message-ID | <[email protected]> |
On 2026/08/07 11:02, Niklas Cassel wrote:
> In the ZBC and ZAC specifications, the requirement is that the write
> granularity matches the physical block size.
>
> However, in the ZNS specification, the requirement is simply that the
> write granularity matches the logical block size.
>
> See:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a805a4fa4fa376bbc145762bb8b09caa2fa8af48
>
> In Linux, there is a zone_write_granularity sysfs property which abstracts
> this away by providing, so let's make use of it.
s/by providing// ? Seems like the sentence is not complete otherwise...
>
> Currently, it is theoretically possible that QEMU presents an inflated
> write granularity for NVMe devices where the physical block size is larger
> than the logical block size.
>
> Fixes: a3c41f06d5a8 ("file-posix: add tracking of the zone write pointers")
> Signed-off-by: Niklas Cassel <[email protected]>
Other than that, looks OK to me.
Reviewed-by: Damien Le Moal <[email protected]>
--
Damien Le Moal
Western Digital Research