Re: [PATCH v3 17/23] monitor: Rename MonitorQMP @mon -> @qmon

Hi

On Thu, Aug 13, 2026 at 12:24 PM Philippe Mathieu-Daudé
<[email protected]> wrote:
>
> On 13/8/26 08:22, [email protected] wrote:
> >> Mechanical change to sanitize using the following patterns:
> >>
> >>    MonitorQMP *qmon  (this patch)
> >>    MonitorHMP *hmon  (following one)
> >>    Monitor *mon
> >>
> >> Rename @mon (and @qmp_mon) as @qmon when the type is MonitorQMP.
> >
> > This patch and the following are conflicting quite directly with
> > the work I have for --disable-hmp.
> > (https://gitlab.com/marcandre.lureau/qemu/-/tree/no-hmp)
> >
> > Can we delay them?
>
> I was expecting something like that, sure, no problem.
> >
> > fwiw, I picked Monitor *mon, MonitorHMP *hmp. I didn't touch MonitorQMP*.
> >
>
> Are you OK I merge patches 1-16 (now all reviewed) in my next
> misc PR?

yes please, asap :)

> I'd like to put #19 and #22 also, which are both HMP and removing
> the "monitor/monitor-internal.h" use out of monitor/ is a good
> cleanup IMHO. If you agree do you mind reviewing them, then I'll
> update the thread mentioning the queued patches.

ok