Re: [PATCH v3 17/23] monitor: Rename MonitorQMP @mon -> @qmon

On 13/8/26 11:26, Daniel P. Berrangé wrote:
> On Wed, Aug 12, 2026 at 11:17:01PM +0200, Philippe Mathieu-Daudé wrote:
>> Mechanical change to sanitize using the following patterns:
>>
>>    MonitorQMP *qmon  (this patch)
>>    MonitorHMP *hmon  (following one)
>>    Monitor *mon
>>
>> Rename @mon (and @qmp_mon) as @qmon when the type is MonitorQMP.
> 
> The more suitable names to me feel like  'mon', 'qmp' and 'hmp',
> not least because we already use them, whereas as have no use
> of qmon/hmon currently.

Interesting, this is what I chose first, then thought I'd receive
comments that this the monitor state being named the same as the
interface used would be confusing. I'll happily redo the rename
(but after Marc-André 'Make HMP optional' series lands).
> 
> 
>>
>> Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
>> ---
>>   monitor/monitor-internal.h |   4 +-
>>   monitor/qmp-cmds-control.c |  18 +--
>>   monitor/qmp.c              | 256 ++++++++++++++++++-------------------
>>   3 files changed, 139 insertions(+), 139 deletions(-)
> 
> With regards,
> Daniel