RE: [PATCH v1] hw/usb/hcd-ehci: Handle get_dwords() failures in async writeback

+ Cédric Le Goater <[email protected]>

> -----Original Message-----
> From: Philippe Mathieu-Daudé <[email protected]>
> Sent: Thursday, August 13, 2026 5:43 PM
> To: Jamin Lin <[email protected]>; [email protected]; Philippe
> Mathieu-Daudé <[email protected]>; Paolo Bonzini <[email protected]>;
> open list:All patches CC here <[email protected]>
> Cc: Troy Lee <[email protected]>
> Subject: Re: [PATCH v1] hw/usb/hcd-ehci: Handle get_dwords() failures in async
> writeback
> 
> On 13/8/26 09:23, Jamin Lin wrote:
> > Coverity reports that ehci_writeback_async_complete_packet() ignores
> > the return value of get_dwords() when reading the QH and qTD.
> >
> > Handle read failures in the same way as QH and qTD verification
> > failures by freeing the packet and returning early.
> >
> > Signed-off-by: Jamin Lin <[email protected]>
> > ---
> >   hw/usb/hcd-ehci.c | 10 +++++-----
> >   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> Fixes: 2b3de6ada5d ("ehci: writeback_async_complete_packet: verify qh and
> qtd")
> Reviewed-by: Philippe Mathieu-Daudé <[email protected]>

Thanks for adding the Fixes tag.
I’ve also added the Resolves tag.

Resolves: Coverity CID 1685236

Jamin