Re: [PATCH v3] qga: implement 'guest-get-fsinfo' for FreeBSD

Reviewed-by: Kostiantyn Kostiuk <[email protected]>

Will be merged after code freeze

On Wed, Aug 12, 2026 at 12:43 PM Roman Bogorodskiy <[email protected]>
wrote:

>   Roman Bogorodskiy wrote:
>
> > Implement the qmp_guest_get_fsinfo() API for FreeBSD.
> > To implement it, reuse build_fs_mount_list() which is already
> > implemented for FreeBSD. Extend the FsMount type to include
> > a string "fromname" attribute to store the disk the FS is mounted from.
> >
> > Disk mapping info is not covered by this implementation.
> >
> > Signed-off-by: Roman Bogorodskiy <[email protected]>
> > Acked-by: Markus Armbruster <[email protected]>
> > Reviewed-by: Kostiantyn Kostiuk <[email protected]>
> > ---
> > Changes since v1:
> >
> >  - Replace g_malloc0() with g_new0(.., 1) for GuestFilesystemInfo
> >
> > Changes since v2:
> >
> >  - Drop the unused 'errp' argument to build_guest_fsinfo() and
> >    clean up the related code.
> >  - Fix leaking string through g_strdup() for a g_path_get_basename()
> >    allocated string.
> >
> >  qga/commands-bsd.c    | 53 ++++++++++++++++++++++++++++++++++++++++++-
> >  qga/commands-common.h |  1 +
> >  qga/commands-posix.c  |  3 +++
> >  qga/qapi-schema.json  | 12 +++++-----
> >  4 files changed, 62 insertions(+), 7 deletions(-)
>
> ping
>
> https://patchew.org/QEMU/[email protected]/
>
>