Re: [PATCH v3 07/49] system: decouple qmp_inject_nmi() from Monitor
Philippe Mathieu-Daudé <[email protected]>
| Newsgroups | gmane.comp.emulators.qemu |
|---|---|
| Message-ID | <[email protected]> |
On 16/8/26 21:12, Marc-André Lureau wrote: > Use first_cpu directly instead of going through monitor_get_cpu_index(), > as this is HMP-territory. QMP doesn't have a `cpu` command, we should > add arguments instead when needed. > > Update the inject-nmi doc to accurately describe per-architecture NMI > delivery. > > Reviewed-by: Daniel P. Berrangé <[email protected]> > Signed-off-by: Marc-André Lureau <[email protected]> > --- > qapi/machine.json | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/qapi/machine.json b/qapi/machine.json > index 2d63c1bac3b4..29ab1cb9d7f4 100644 > --- a/qapi/machine.json > +++ b/qapi/machine.json > @@ -432,10 +432,10 @@ > ## > # @inject-nmi: > # > -# Injects a Non-Maskable Interrupt (machine specific: for example on > -# s390x CCW only the first vCPU receives the NMI, but on x86 machines > -# all vCPUs receive it). The command fails when the guest doesn't > -# support injecting. > +# Injects a Non-Maskable Interrupt into the virtual machine. The NMI > +# is delivered to all vCPUs (x86, hppa, ppc64) or to the first vCPU > +# (s390). The command fails when the guest doesn't support > +# injecting. You can drop this one.