Re: [PATCH 7/7] target/ppc: Add ICBT support for ISA version 2.07

Greetings,

I tested the patch on my setup and can confirm it fixes the "illegal 
instruction" issue I was seeing with HTX mdt.all on a KVM guest.

*Issue observed (before patch) :*
With HTX mdt.all running on the guest, hxecpu would crash with:

/"hxecpu[7487]: illegal instruction (4) at 7fffbc401054 nip 7fffbc401054 
lr 7fffbc400adc code 1"/

*After applying this patch:*
The illegal instruction errors are no longer seen in dmesg, and hxecpu 
runs cleanly through HTX.


Tested-by: Tasmiya Nalatwad <[email protected]>



On 15/07/26 6:26 pm, Chinmay Rath wrote:
> The summary of changes in Power ISA version 2.07B mentions :
> "ICBT instruction has been moved from the Embedded category
> to the Base category".
> Updating ICBT flag for the same.
>
> While we are at it, correct the invalid mask as per the ISA as well.
>
> Signed-off-by: Chinmay Rath<[email protected]>
> ---
>   target/ppc/translate.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target/ppc/translate.c b/target/ppc/translate.c
> index 8dab54ccee..3cd849c706 100644
> --- a/target/ppc/translate.c
> +++ b/target/ppc/translate.c
> @@ -4559,8 +4559,8 @@ GEN_HANDLER2_E(tlbilx_booke206, "tlbilx", 0x1F, 0x12, 0x00, 0x03800001,
>   GEN_HANDLER(wrtee, 0x1F, 0x03, 0x04, 0x000FFC01, PPC_WRTEE),
>   GEN_HANDLER(wrteei, 0x1F, 0x03, 0x05, 0x000E7C01, PPC_WRTEE),
>   GEN_HANDLER(dlmzb, 0x1F, 0x0E, 0x02, 0x00000000, PPC_440_SPEC),
> -GEN_HANDLER2_E(icbt_440, "icbt", 0x1F, 0x16, 0x00, 0x03E00001,
> -               PPC_BOOKE, PPC2_BOOKE206),
> +GEN_HANDLER2_E(icbt_440, "icbt", 0x1F, 0x16, 0x00, 0x02000001,
> +               PPC_BOOKE, (PPC2_BOOKE206 | PPC2_ISA207)),
>   GEN_HANDLER2(icbt_440, "icbt", 0x1F, 0x06, 0x08, 0x03E00001,
>                PPC_440_SPEC),
>   GEN_HANDLER(mfvscr, 0x04, 0x2, 0x18, 0x001ff800, PPC_ALTIVEC),