Re: [PATCH v3 07/13] target/hexagon: add semihosting support

On Mon, 17 Aug 2026 06:23:03 +0200 =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= <[email protected]> wrote:
>
> Hi Matheus,
> 
> On 20/7/26 19:41, Matheus Tavares Bernardino wrote:
> >
> > diff --git a/hw/hexagon/Kconfig b/hw/hexagon/Kconfig
> > index 52065ab3b22..3a8ff17812b 100644
> > --- a/hw/hexagon/Kconfig
> > +++ b/hw/hexagon/Kconfig
> > @@ -2,6 +2,7 @@ config HEX_DSP
> >       bool
> >       default y
> >       depends on HEXAGON
> > +    select ARM_COMPATIBLE_SEMIHOSTING
> 
> Here we select explicitly ...
> 
> >   
> >   config HEX_VIRT
> >       bool
> 
> 
> > diff --git a/target/hexagon/meson.build b/target/hexagon/meson.build
> > index 59cb09c1070..69f01bd2f70 100644
> > --- a/target/hexagon/meson.build
> > +++ b/target/hexagon/meson.build
> > @@ -262,6 +262,9 @@ hexagon_softmmu_ss.add(files(
> >       'machine.c',
> >   ))
> >   
> > +hexagon_softmmu_ss.add(when: 'CONFIG_ARM_COMPATIBLE_SEMIHOSTING',
> > +                       if_true: files('common-semi-target.c'))
> 
> ... so optionally including this file is odd. If we still want it
> optional, then we need stubs for symbols with external linkage.

Oops, this was likely a copy-paste error from target/arm/meson.build. I'll
include the file unconditionally instead, thanks for the heads up.