Re: [PATCH v3 0/7] migration/cpr: support vhost-vsock devices

Stefano Garzarella <[email protected]>
Newsgroups gmane.comp.emulators.qemu
Message-ID <aoR62LTt0K7oWNb7@sgarzare-redhat>
On Tue, Aug 18, 2026 at 02:02:10PM +0300, Andrey Drobyshev wrote:
>On 8/11/26 5:12 PM, Andrey Drobyshev wrote:
>> On 6/30/26 9:35 PM, Maciej S. Szmigiero wrote:
>>> On 26.06.2026 18:46, Andrey Drobyshev wrote:
>>>> v2 -> v3:
>>>>
>>>> Re-design device ownership hand-off (suggested by Dongli).  Do not rely
>>>> on SETUP migration notifiers, as this approach forces us to reorder
>>>> generic migration code (see v2 discussion).  Instead:
>>>>
>>>>    * .pre_save() releases ownership on the source (RESET_OWNER) once VM
>>>>      is stopped;
>>>>    * .realize() is adjusted to defer device ownership acquisition for an
>>>>      incoming CPR;
>>>>    * .post_load() actually claims the device (VHOST_SET_OWNER);
>>>>    * FAILED migration event callback re-aquires the ownership on the
>>>>      source after re_save released it.
>>>>
>>>> v2: https://lore.kernel.org/qemu-devel/[email protected]
>>>>
>>>> Andrey Drobyshev (7):
>>>>    vhost: add vhost_reset_owner op
>>>>    vhost-vsock: don't reset connections during CPR
>>>>    vhost-vsock: fix FD leak in realize()
>>>>    vhost-vsock: preserve vhost FD during CPR
>>>>    vhost: factor out vhost_dev_init_backend()
>>>>    vhost: add vhost_dev_set_owner() / vhost_dev_reset_owner() helpers
>>>>    vhost-vsock: hand off device ownership across CPR
>>>>
>>> These patches look okay CPR-wise, so:
>>> Acked-by: Maciej S. Szmigiero <[email protected]> # for CPR
>>>
>>> But the vsock parts still need review by their maintainers/reviewers.
>>>
>>> Thanks,
>>> Maciej
>>>
>>
>> FYI the kernel counterpart series adding VHOST_RESET_OWNER ioctl to
>> vsock ended up in Michael's vhost tree ([1], commits
>> 6236e765f16d^..c7bfb8815d83).
>>
>> Therefore - friendly ping for this series.
>>
>> [1] https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git
>>
>> Andrey
>
>Another friendly ping
>

Sorry for the long time on my side, and thanks for pings :-)

I left some comments, but overall LGTM.
I'm not a CPR/migration expert, so my comments are more related to 
vhost/vsock.

Thanks,
Stefano
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.