Re: [PATCH] target/hexagon: Add HMP info tlb command

Hi

On Tue, Aug 18, 2026 at 11:33 PM Brian Cain <[email protected]> wrote:
>
> Signed-off-by: Brian Cain <[email protected]>
> ---
>  target/hexagon/monitor.c   | 23 +++++++++++++++++++++++

please name it something like hmp-cmds.c, so we can easily compile it out later

otherwise, lgtm
Reviewed-by: Marc-André Lureau <[email protected]>


>  hmp-commands-info.hx       |  3 ++-
>  target/hexagon/meson.build |  1 +
>  3 files changed, 26 insertions(+), 1 deletion(-)
>  create mode 100644 target/hexagon/monitor.c
>
> diff --git a/target/hexagon/monitor.c b/target/hexagon/monitor.c
> new file mode 100644
> index 00000000000..150045769cc
> --- /dev/null
> +++ b/target/hexagon/monitor.c
> @@ -0,0 +1,23 @@
> +/*
> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> + *
> + * SPDX-License-Identifier: GPL-2.0-or-later
> + */
> +
> +#include "qemu/osdep.h"
> +#include "cpu.h"
> +#include "hex_mmu.h"
> +#include "monitor/hmp.h"
> +#include "monitor/monitor.h"
> +
> +void hmp_info_tlb(Monitor *mon, const QDict *qdict)
> +{
> +    CPUArchState *env = mon_get_cpu_env(mon);
> +
> +    if (!env) {
> +        monitor_printf(mon, "No CPU available\n");
> +        return;
> +    }
> +
> +    dump_mmu(mon, env);
> +}
> diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx
> index 82134eb6c21..0d31fb8a84c 100644
> --- a/hmp-commands-info.hx
> +++ b/hmp-commands-info.hx
> @@ -193,7 +193,8 @@ ERST
>          .help       = "show virtual to physical memory mappings",
>          .cmd        = hmp_info_tlb,
>          .arch_bitmask = QEMU_ARCH_I386 | QEMU_ARCH_SH4 | QEMU_ARCH_SPARC \
> -                        | QEMU_ARCH_PPC | QEMU_ARCH_XTENSA | QEMU_ARCH_M68K,
> +                        | QEMU_ARCH_PPC | QEMU_ARCH_XTENSA | QEMU_ARCH_M68K \
> +                        | QEMU_ARCH_HEXAGON,
>      },
>
>  SRST
> diff --git a/target/hexagon/meson.build b/target/hexagon/meson.build
> index 4c921eee73b..a84a35106f5 100644
> --- a/target/hexagon/meson.build
> +++ b/target/hexagon/meson.build
> @@ -261,6 +261,7 @@ hexagon_softmmu_ss.add(files(
>      'hex_interrupts.c',
>      'hexswi.c',
>      'machine.c',
> +    'monitor.c',
>  ))
>
>  #
> --
> 2.34.1
>
>