Re: [PATCH v2 06/32] system: check security for machine types

[email protected]
Newsgroups gmane.comp.emulators.qemu
Message-ID <178708450916.1320462.5283210372449603542.b4-review@b4>
> This wires up the machine creation code to apply the compat policy
> security check.
> 
> Signed-off-by: Daniel P. Berrangé <[email protected]>
> Message-ID: <[email protected]>
>
> diff --git a/system/vl.c b/system/vl.c
> index 38c6caf52467..716bf6d490a7 100644
> --- a/system/vl.c
> +++ b/system/vl.c
> @@ -2182,10 +2182,19 @@ static void qemu_create_machine_containers(Object *machine)
>      }
>  }
>  
> -static void qemu_create_machine(QDict *qdict)
> +static int qemu_create_machine(QDict *qdict)


>  {
>      MachineClass *machine_class = select_machine(qdict, &error_fatal);
>      object_set_machine_compat_props(machine_class->compat_props);
> +    Error *local_err;

Move local_err decl one line before, and initialize it to NULL.

-- 
Marc-André Lureau <[email protected]>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.