Re: [PATCH v2 8/9] hw/arm/raspi4b: Drop board_rev for 32bit hosts

On 18/8/26 19:20, Peter Xu wrote:
> QEMU has switched to 64bit-only hosts for all system/user emulations.
> 
> Signed-off-by: Peter Xu <[email protected]>
> ---
>   hw/arm/raspi4b.c | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/hw/arm/raspi4b.c b/hw/arm/raspi4b.c
> index e1595a875f..5f7abbb4c4 100644
> --- a/hw/arm/raspi4b.c
> +++ b/hw/arm/raspi4b.c
> @@ -111,11 +111,7 @@ static void raspi4b_machine_class_init(ObjectClass *oc, const void *data)
>       MachineClass *mc = MACHINE_CLASS(oc);
>       RaspiBaseMachineClass *rmc = RASPI_BASE_MACHINE_CLASS(oc);
>   
> -#if HOST_LONG_BITS == 32
> -    rmc->board_rev = 0xa03111; /* Revision 1.1, 1 Gb RAM */
> -#else
>       rmc->board_rev = 0xb03115; /* Revision 1.5, 2 Gb RAM */
> -#endif
>       raspi_machine_class_common_init(mc, rmc->board_rev);
Here I'd rather keep the machine. IIRC someone already suggested
to adapt the board_rev with the CLI provided memory size.
An improvement for tomorrow, meanwhile:
Reviewed-by: Philippe Mathieu-Daudé <[email protected]>