Re: [patch] Add Logging Support for SID Components

"Frank Ch. Eigler" <[email protected]>
Newsgroups gmane.comp.emulators.sid.devel
Message-ID <[email protected]>
Hi -

> The attached patch adds logging support for sid components in 3 stages:
> [...]

Looks fine - good use of virtual inheritance.  A few minor things
I might have done differently:

- make a new component type for named file I/O, instead of
  changing sid-io-stdio; after all, stdio is bidirectional,
  meant to be interactive
- think of some other way to call stdout than "*"
- make logging output buffering dependent on an attribute (set as the last
  gasp of configuration) instead of pin-connectedness
- having a C++ flavour API (instead of printf()) for the logging function


- FChE
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.