Re: [patch] Add Logging Support for SID Components

Hi -

> This new patch replaces the previous one and addresses some of the 
> concerns below....

Addressing my suggestions was not intended as a prerequisite for
committing your previous version.

The new version seems to have at least one actual problem though:
the way that the buffer array is managed.  Its allocation/deallocation
strategy should be consistent (probably "new char[]" and "delete[] char")
regardless of the availability of the various *sprintf variants.  It should
probably not even be in #if/#endif markers.  The new code appears to be
able to hit free() even though malloc() was never called.

- FChE

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE+5J6WVZbdDOm/ZT0RApzxAJ9XAgnC4pTa8F2j/wxrXrbi4D/IOQCfd3Mt
KYyUpx9iPRznOn+ntyXEkZU=
=fyEu
-----END PGP SIGNATURE-----