Re: [patch][rfa] Add "active" pin to sid-sched

Dave Brolley <[email protected]>
Newsgroups gmane.comp.emulators.sid.devel
Message-ID <[email protected]>

Frank Ch. Eigler wrote:

>Looks fine to commit, though please consider not using a new
>"active_p" member variable in order to send edges on the active
>pin.  This can be done by replacing ...
>
>  
>
>>+ 	  // Drive the active pin if the threshold has been crossed.
>>+ 	  if (UNLIKELY(! this->active_p))
>>+ 	    {
>>+ 	      this->active_pin.drive (1);
>>+ 	      this->active_p = true;
>>+ 	    }
>>+ 
>>    
>>
>
>with
>	  if (this->active_pin.sense() != 1)
>	    this->active_pin->drive(1);
>
>and a corresponding change for the 0 transition.
>  
>
This doesn't work because active_pin is an output_pin.

Dave
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.