[Git][wine/wine][master] wined3d: Don't print opcodes for cs padding packets.

"Alexandre Julliard (@julliard) via Wine-commits" <[email protected]> Wed, 21 Jan 2026 16:09:29 -0600
Newsgroups gmane.comp.emulators.wine.cvs
Message-ID <[email protected]>

Alexandre Julliard pushed to branch master at wine / wine


Commits:
9d44162a by Francisco Casas at 2026-01-21T10:44:39+01:00
wined3d: Don't print opcodes for cs padding packets.

Command stream queues are implemented using a fixed size array.

This implementation requires NOP packets to be inserted at the end
sometimes, so that these packets can be skipped and the head pointer
can be properly move back to the beginning.

Furthermore, sometimes it is necessary to insert padding packets that
contain zero data (besides the size field), so they don't even have space
for the NOP opcode. Their opcode shouldn't be read.

Currently it is possible to get trace messages such as this:

    0484:trace:d3d:wined3d_cs_queue_submit Queuing op UNKNOWN_OP(0x34) at 06EF1C8C.

for these padding packets. In this case the packet was from cs->queue[0]
but 0x34 was actually cs->queue[1].size.

Depending of the out-of-bounds data, spurious yet valid opcodes could be
reported, so we fix that.

- - - - -


1 changed file:

- dlls/wined3d/cs.c


View it on GitLab: https://gitlab.winehq.org/wine/wine/-/commit/9d44162adac6b91fb3306c091bbd45df38f63f5e

-- 
View it on GitLab: https://gitlab.winehq.org/wine/wine/-/commit/9d44162adac6b91fb3306c091bbd45df38f63f5e
You're receiving this email because of your account on gitlab.winehq.org.