[Git][wine/wine][master] 2 commits: wined3d: Clear backup_dc and backup_wnd when deleting them.

"Alexandre Julliard (@julliard) via Wine-commits" <[email protected]> Wed, 04 Feb 2026 15:36:26 -0600
Newsgroups	gmane.comp.emulators.wine.cvs
Message-ID	<[email protected]>
----==_mimepart_6983bbda64c7c_37bc84f99e81475417
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit



Alexandre Julliard pushed to branch master at wine / wine


Commits:
76f152e0 by Elizabeth Figura at 2026-02-04T22:21:41+01:00
wined3d: Clear backup_dc and backup_wnd when deleting them.

If we were using a backup DC and then perform a reset, we will clear the DC, but
not zero it, meaning that once 3D is initialized again, we may eventually end up
trying to use the same backup DC which has been deleted. Fix this by also
zeroing the DC pointer.

- - - - -
98a441dd by Zhiyi Zhang at 2026-02-04T22:21:42+01:00
wined3d: Reset internal_format_set when using the backup DC.

internal_format_set is only relevant to the real DC, but it's checked before
setting the format on the backup DC as well. If the real DC stops being valid,
we need to reset the field to make sure we actually set the format on the backup
DC.

- - - - -


4 changed files:

- dlls/d3d8/tests/device.c
- dlls/d3d9/tests/device.c
- dlls/wined3d/context_gl.c
- dlls/wined3d/device.c


View it on GitLab: https://gitlab.winehq.org/wine/wine/-/compare/410eda098d0d338c079a7b195e221d5db91d5aad...98a441ddf9d857ae21e4383eaee628deb6947a27

-- 
View it on GitLab: https://gitlab.winehq.org/wine/wine/-/compare/410eda098d0d338c079a7b195e221d5db91d5aad...98a441ddf9d857ae21e4383eaee628deb6947a27
You're receiving this email because of your account on gitlab.winehq.org.



----==_mimepart_6983bbda64c7c_37bc84f99e81475417
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www=
.w3.org/TR/REC-html40/loose.dtd">
<html lang=3D"en" style=3D'--code-editor-font: var(--default-mono-font, "=
GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, =
Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospac=
e;'>
<head>
<meta content=3D"text/html; charset=3Dutf-8" http-equiv=3D"Content-Type">=

<title>
GitLab
</title>

<style data-premailer=3D"ignore" type=3D"text/css">
a { color: #1068bf; }
</style>


<style>img {
max-width: 100%; height: auto;
}
body {
font-size: .875rem;
}
body {
-webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px;
}
body {
font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Ro=
boto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Colo=
r Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size=
: inherit;
}
</style>
</head>
<body style=3D'font-size: inherit; -webkit-text-shadow: rgba(255,255,255,=
.01) 0 0 1px; font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont=
,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-ser=
if,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emo=
ji";'>
<div class=3D"content">

<h3 style=3D"margin-top: 20px; margin-bottom: 10px;">
Alexandre Julliard pushed to branch master at <a href=3D"https://gitlab.w=
inehq.org/wine/wine">wine / wine</a>
</h3>
<h4 style=3D"margin-top: 10px; margin-bottom: 10px;">
Commits:
</h4>
<ul>
<li>
<strong style=3D"font-weight: 600;"><a href=3D"https://gitlab.winehq.org/=
wine/wine/-/commit/76f152e01f2b4caf9bab155aa124461b0677cbca">76f152e0</a>=
</strong>
<div>
<span> by Elizabeth Figura </span> <i> at 2026-02-04T22:21:41+01:00 </i>
</div>
<pre class=3D"commit-message" style=3D'white-space: pre-wrap; display: bl=
ock; font-size: 14px; color: #3a383f; position: relative; font-family: "G=
itLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation M=
ono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida co=
nsole", monospace; font-variant-ligatures: none; word-break: break-all; w=
ord-wrap: break-word; background-color: #fbfafd; border-radius: 2px; marg=
in: 0; padding: 8px 12px; border: 1px solid #dcdcde;'>wined3d: Clear back=
up_dc and backup_wnd when deleting them.

If we were using a backup DC and then perform a reset, we will clear the =
DC, but
not zero it, meaning that once 3D is initialized again, we may eventually=
 end up
trying to use the same backup DC which has been deleted. Fix this by also=

zeroing the DC pointer.
</pre>
</li>
<li>
<strong style=3D"font-weight: 600;"><a href=3D"https://gitlab.winehq.org/=
wine/wine/-/commit/98a441ddf9d857ae21e4383eaee628deb6947a27">98a441dd</a>=
</strong>
<div>
<span> by Zhiyi Zhang </span> <i> at 2026-02-04T22:21:42+01:00 </i>
</div>
<pre class=3D"commit-message" style=3D'white-space: pre-wrap; display: bl=
ock; font-size: 14px; color: #3a383f; position: relative; font-family: "G=
itLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liberation M=
ono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lucida co=
nsole", monospace; font-variant-ligatures: none; word-break: break-all; w=
ord-wrap: break-word; background-color: #fbfafd; border-radius: 2px; marg=
in: 0; padding: 8px 12px; border: 1px solid #dcdcde;'>wined3d: Reset inte=
rnal_format_set when using the backup DC.

internal_format_set is only relevant to the real DC, but it's checked bef=
ore
setting the format on the backup DC as well. If the real DC stops being v=
alid,
we need to reset the field to make sure we actually set the format on the=
 backup
DC.
</pre>
</li>
</ul>
<h4 style=3D"margin-top: 10px; margin-bottom: 10px;">
4 changed files:
</h4>
<ul>
<li class=3D"file-stats">
<a href=3D"https://gitlab.winehq.org/wine/wine/-/compare/410eda098d0d338c=
079a7b195e221d5db91d5aad...98a441ddf9d857ae21e4383eaee628deb6947a27#8dcd3=
9f3ce7a30da5a0a0cc4bf9dba516814a9f7">
dlls/d3d8/tests/device.c
</a>
</li>
<li class=3D"file-stats">
<a href=3D"https://gitlab.winehq.org/wine/wine/-/compare/410eda098d0d338c=
079a7b195e221d5db91d5aad...98a441ddf9d857ae21e4383eaee628deb6947a27#b5b1a=
d18b660096bc85debd98319c4c2d6bf67dc">
dlls/d3d9/tests/device.c
</a>
</li>
<li class=3D"file-stats">
<a href=3D"https://gitlab.winehq.org/wine/wine/-/compare/410eda098d0d338c=
079a7b195e221d5db91d5aad...98a441ddf9d857ae21e4383eaee628deb6947a27#07d3b=
457bf8175d10f7d9ecec877c1c047fa8714">
dlls/wined3d/context_gl.c
</a>
</li>
<li class=3D"file-stats">
<a href=3D"https://gitlab.winehq.org/wine/wine/-/compare/410eda098d0d338c=
079a7b195e221d5db91d5aad...98a441ddf9d857ae21e4383eaee628deb6947a27#52757=
952624f881d229fda807b2824f20d2f9055">
dlls/wined3d/device.c
</a>
</li>
</ul>

</div>
<div class=3D"footer" style=3D"margin-top: 10px;">
<p style=3D"font-size: small; color: #626168;">
=E2=80=94
<br>
<a href=3D"https://gitlab.winehq.org/wine/wine/-/compare/410eda098d0d338c=
079a7b195e221d5db91d5aad...98a441ddf9d857ae21e4383eaee628deb6947a27">View=
 it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target=3D"_blan=
k" rel=3D"noopener noreferrer" href=3D"https://gitlab.winehq.org">gitlab.=
winehq.org</a>. <a href=3D"https://gitlab.winehq.org/-/profile/notificati=
ons" target=3D"_blank" rel=3D"noopener noreferrer" class=3D"mng-notif-lin=
k">Manage all notifications</a> =C2=B7 <a href=3D"https://gitlab.winehq.o=
rg/help" target=3D"_blank" rel=3D"noopener noreferrer" class=3D"help-link=
">Help</a>
<span style=3D"color: transparent; font-size: 0; display: none; overflow:=
 hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0;">
Notification message regarding https://gitlab.winehq.org/wine/wine/-/comp=
are/410eda098d0d338c079a7b195e221d5db91d5aad...98a441ddf9d857ae21e4383eae=
e628deb6947a27 at 1770240986
</span>



</p>
</div>
</body>
</html>

----==_mimepart_6983bbda64c7c_37bc84f99e81475417--