Re: Question about `wineboot: Create section objects for known dlls' patch

Alexandre Julliard <[email protected]> Thu, 03 Apr 2025 14:02:39 +0200
Newsgroups gmane.comp.emulators.wine.devel
Message-ID <87a58xpi5c.fsf@wine>
Mitch Wilkinson <[email protected]> writes:

> I have a question about patch 81ea1e7a20c (wineboot: Create section objects for known dlls., 2025-03-31) recently landed to `Wine
> development'.
>  
> Do I understand correctly, that create_known_dlls() function initializes (and then clears) internal list of KnownDLLs, creates NT section for each
> that KnownDLL and its import dependency and then closes all those sections?  Thus, effectively create_known_dlls() does nothing -- the dlls list
> is on its stack anyway, NT sections are created and almost immediately closed.  What the purpose of create_known_dlls() function?  May be I
> missed something, sorry, but please explain what happens there.

The section objects are created with OBJ_PERMANENT, so closing them
doesn't delete them.

-- 
Alexandre Julliard
[email protected]