Re: [PATCH 2/4] selftests: ntsync: fix wake_all CREATE_EVENT fd expectation

On Saturday, 27 June 2026 21:42:37 CDT Iv=C3=A1n Ezequiel Rodriguez wrote:
> wake_all used EXPECT_EQ(0, objs[3]) after NTSYNC_IOC_CREATE_EVENT.
> The ioctl returns a non-negative file descriptor on success; check
> EXPECT_LE(0, objs[3]) like the other CREATE_* paths. The incorrect
> expectation was noted on list (Mar 2025) but is still present in
> mainline.
>=20
> Signed-off-by: Iv=C3=A1n Ezequiel Rodriguez <[email protected]>
> ---
>  tools/testing/selftests/drivers/ntsync/ntsync.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/tools/testing/selftests/drivers/ntsync/ntsync.c b/tools/test=
ing/selftests/drivers/ntsync/ntsync.c
> index e6a37214aa46..12b4b81edf7f 100644
> --- a/tools/testing/selftests/drivers/ntsync/ntsync.c
> +++ b/tools/testing/selftests/drivers/ntsync/ntsync.c
> @@ -968,7 +968,7 @@ TEST(wake_all)
>  	auto_event_args.manual =3D false;
>  	auto_event_args.signaled =3D true;
>  	objs[3] =3D ioctl(fd, NTSYNC_IOC_CREATE_EVENT, &auto_event_args);
> -	EXPECT_EQ(0, objs[3]);
> +	EXPECT_LE(0, objs[3]);
> =20
>  	wait_args.timeout =3D get_abs_timeout(1000);
>  	wait_args.objs =3D (uintptr_t)objs;
>=20

Reviewed-by: Elizabeth Figura <[email protected]>

=2D-

This was already sent as <https://lore.kernel.org/all/20250314071454.201697=
[email protected]/> and never committed.