Re: [PATCH 0/4] ntsync documentation, selftests, and owner validation
Elizabeth Figura <[email protected]> Wed, 01 Jul 2026 11:45:13 -0500
| Newsgroups | gmane.linux.kernel,gmane.comp.emulators.wine.devel |
|---|---|
| Message-ID | <3049825.e9J7NaK4W3@camazotz> |
On Saturday, 27 June 2026 21:42:35 CDT Iv=C3=A1n Ezequiel Rodriguez wrote: > This series improves ntsync without changing wait/wake semantics: >=20 > 1/4 =E2=80=94 Align Documentation/userspace-api/ntsync.rst with > include/uapi/linux/ntsync.h (ioctl macro names and struct layout). >=20 > 2/4 =E2=80=94 Fix wake_all selftest: CREATE_EVENT returns an fd, not zer= o. >=20 > 3/4 =E2=80=94 Add selftests for documented EINVAL cases (zero owner, non= =2Dzero > pad, cross-instance object use). >=20 > 4/4 =E2=80=94 Reject wait ioctls when owner is zero, matching the docume= nted > uAPI (3/4 depends on 4/4 for the owner tests). >=20 > Patch 4/4 closes a spec gap: Documentation/userspace-api/ntsync.rst > requires EINVAL when wait owner is zero, but setup_wait() only validated > pad and flags. Unlock/kill mutex ioctls already reject owner =3D=3D 0. >=20 > Testing: > - scripts/checkpatch.pl --strict --no-tree: clean (4/4 patches) > - make headers && make -C tools/testing/selftests TARGETS=3Ddrivers/ntsync > - Kernel 7.1.0-ntsync-test+ (CONFIG_NTSYNC=3Dy), QEMU x86_64 initramfs: > tools/testing/selftests/drivers/ntsync/ntsync =E2=80=94 12/12 PASS, > including wake_all and wait_args_validation > - On 6.17.0-35-generic with the distro ntsync.ko (without patch 4/4): > wait_args_validation fails on owner=3D=3D0 (wait proceeds instead of > EINVAL), confirming the gap this series fixes >=20 > Elizabeth Figura <[email protected]> > [email protected] > --- > Documentation/userspace-api/ntsync.rst | 22 +++++----- > tools/testing/selftests/drivers/ntsync/ntsync.c | 45 ++++++++++++++++++++ > drivers/misc/ntsync.c | 3 ++ > 3 files changed, 59 insertions(+), 11 deletions(-) >=20 > Iv=C3=A1n Ezequiel Rodriguez (4): > docs: ntsync: align uAPI ioctl names and struct layout with ntsync.h > selftests: ntsync: fix wake_all CREATE_EVENT fd expectation > selftests: ntsync: add wait argument validation tests > ntsync: reject wait ioctls with zero owner >=20 > -- > 2.43.0 >=20 Some of these changes overlap with changes already sent in <https://lore.ke= rnel.org/all/[email protected]/>, which were never= applied. This series does not overlap with patches 2/4 and 3/4 from that s= eries.