Re: [PATCH v2] vbscript/tests: Fix test for WeekDayName(foo, bar, 0).

Hi Alex,

On 30.10.2017 18:17, Alex Henrie wrote:
> -static BOOL is_lang_english(void)
> +static void detect_locale(void)
>  {
> -    static HMODULE hkernel32 = NULL;
> -    static LANGID (WINAPI *pGetThreadUILanguage)(void) = NULL;
> -    static LANGID (WINAPI *pGetUserDefaultUILanguage)(void) = NULL;
> +    is_english = (PRIMARYLANGID(GetThreadUILanguage()) == LANG_ENGLISH &&
> +                  PRIMARYLANGID(GetUserDefaultUILanguage()) == LANG_ENGLISH &&
> +                  PRIMARYLANGID(GetUserDefaultLangID()) == LANG_ENGLISH);


GetThreadUILanguage is available since Vista, so we still need to check it in runtime. BTW, I'm not sure what's up with TestBot. There are failures (as expected), but it has OK status on patch status page.


Thanks,
Jacek