[Tools] testbot/web: Document that the Redirect() calls don't return.
Francois Gouget <[email protected]> Mon, 13 Nov 2017 17:07:06 +0100 (CET)
| Newsgroups | gmane.comp.emulators.wine.patches |
|---|---|
| Message-ID | <E1eEHGM-0005SG-VX@amboise> |
Signed-off-by: Francois Gouget <[email protected]> --- testbot/web/JobDetails.pl | 6 +++--- testbot/web/Login.pl | 2 +- testbot/web/Submit.pl | 6 +++--- testbot/web/admin/UserDetails.pl | 6 +++--- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/testbot/web/JobDetails.pl b/testbot/web/JobDetails.pl index a4ed9944..a9bb2318 100644 --- a/testbot/web/JobDetails.pl +++ b/testbot/web/JobDetails.pl @@ -44,7 +44,7 @@ sub _initialize($$$) $self->{Job} = CreateJobs()->GetItem($JobId); if (!defined $self->{Job}) { - $self->Redirect("/index.pl"); + $self->Redirect("/index.pl"); # does not return } $self->{JobId} = $JobId; @@ -168,7 +168,7 @@ sub OnCancel($) return !1; } - $self->Redirect("/JobDetails.pl?Key=" . $self->{JobId}); + $self->Redirect("/JobDetails.pl?Key=" . $self->{JobId}); # does not return exit; } @@ -190,7 +190,7 @@ sub OnRestart($) return !1; } - $self->Redirect("/JobDetails.pl?Key=" . $self->{JobId}); + $self->Redirect("/JobDetails.pl?Key=" . $self->{JobId}); # does not return exit; } diff --git a/testbot/web/Login.pl b/testbot/web/Login.pl index 95c2286d..99757c54 100644 --- a/testbot/web/Login.pl +++ b/testbot/web/Login.pl @@ -138,7 +138,7 @@ sub OnLogIn($) { $Target = "/index.pl"; } - $self->Redirect(MakeSecureURL($Target)); + $self->Redirect(MakeSecureURL($Target)); # does not return exit; } diff --git a/testbot/web/Submit.pl b/testbot/web/Submit.pl index 4f682a92..00d3a927 100644 --- a/testbot/web/Submit.pl +++ b/testbot/web/Submit.pl @@ -921,7 +921,7 @@ sub OnSubmit($) return !1; } - $self->Redirect("/JobDetails.pl?Key=$JobKey"); + $self->Redirect("/JobDetails.pl?Key=$JobKey"); # does not return exit; } @@ -949,11 +949,11 @@ sub OnOK($) if (defined($self->GetParam("JobKey"))) { - $self->Redirect("/JobDetails.pl?Key=" . $self->GetParam("JobKey")); + $self->Redirect("/JobDetails.pl?Key=" . $self->GetParam("JobKey")); # does not return } else { - $self->Redirect("/index.pl"); + $self->Redirect("/index.pl"); # does not return } } diff --git a/testbot/web/admin/UserDetails.pl b/testbot/web/admin/UserDetails.pl index 022a4a0b..d24e6759 100644 --- a/testbot/web/admin/UserDetails.pl +++ b/testbot/web/admin/UserDetails.pl @@ -73,7 +73,7 @@ sub OnApprove($) return !1 if (!$self->Save()); $self->{ErrMessage} = $self->{Item}->Approve(); return !1 if (defined $self->{ErrMessage}); - $self->RedirectToList(); + $self->RedirectToList(); # does not return exit; } @@ -86,7 +86,7 @@ sub OnReject($) return !1 if (defined $self->{ErrMessage}); # Forcefully log out that user by deleting his web sessions DeleteSessions($self->{Item}); - $self->RedirectToList(); + $self->RedirectToList(); # does not return exit; } @@ -100,7 +100,7 @@ sub OnOK($) # Forcefully log out that user by deleting his web sessions DeleteSessions($self->{Item}); } - $self->RedirectToList(); + $self->RedirectToList(); # does not return exit; } -- 2.14.2