CVS: winex/dlls/dbghelp dbghelp_private.h, 1.4, 1.5 minidump.c, 1.4, 1.5 symbol.c, 1.6, 1.7

[email protected] 31 Aug 2007 12:55:41 -0000
Newsgroups gmane.comp.emulators.winex.cvs
Message-ID <[email protected]>
Subject: winex/dlls/dbghelp dbghelp_private.h,1.4,1.5 minidump.c,1.4,1.5 symbol.c,1.6,1.7Update of /var/lib/cvsd/cvsroot/winex/dlls/dbghelp
In directory agravaine:/tmp/cvs-serv3600/dlls/dbghelp

Modified Files:
	dbghelp_private.h minidump.c symbol.c 
Log Message:
prevented some long function names from being printed
trac #2034

- prevented long function names from being printed when processing a PDB file.  Function names will now be truncated at 256 characters.
- added some event traces to the MiniDumpWriteDump() function



Index: dbghelp_private.h
===================================================================
RCS file: /var/lib/cvsd/cvsroot/winex/dlls/dbghelp/dbghelp_private.h,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -d -r1.4 -r1.5
--- dbghelp_private.h	30 Aug 2007 14:18:20 -0000	1.4
+++ dbghelp_private.h	31 Aug 2007 12:55:39 -0000	1.5
@@ -37,6 +37,8 @@
 #include "wine-lgpl/cvconst.h"
 
 /* #define USE_STATS */
+#define FUNCTION_NAME_FORMAT    "%.256s"
+
 
 struct pool /* poor's man */
 {

Index: minidump.c
===================================================================
RCS file: /var/lib/cvsd/cvsroot/winex/dlls/dbghelp/minidump.c,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -d -r1.4 -r1.5
--- minidump.c	30 Aug 2007 14:19:15 -0000	1.4
+++ minidump.c	31 Aug 2007 12:55:39 -0000	1.5
@@ -758,6 +758,10 @@
     struct dump_context dc;
 
 
+    TRACE("creating a minidump (hProcess = 0x%x, pid = 0x%08lx, hFile = 0x%x, DumpType = 0x%08x, exceptParam = %p, userStream = %p, callbackParam = %p)\n",
+            hProcess, pid, hFile, DumpType, ExceptionParam, UserStreamParam, CallbackParam);
+
+
     dc.hProcess = hProcess;
     dc.hFile = hFile;
     dc.pid = pid;
@@ -891,6 +895,7 @@
     HeapFree(GetProcessHeap(), 0, dc.mem);
     HeapFree(GetProcessHeap(), 0, dc.module);
 
+    TRACE("minidump performed successfully\n");
     return TRUE;
 }
 

Index: symbol.c
===================================================================
RCS file: /var/lib/cvsd/cvsroot/winex/dlls/dbghelp/symbol.c,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -d -r1.6 -r1.7
--- symbol.c	30 Aug 2007 14:19:57 -0000	1.6
+++ symbol.c	31 Aug 2007 12:55:39 -0000	1.7
@@ -221,7 +221,7 @@
     struct symt_public* sym;
     struct symt**       p;
 
-    TRACE_(dbghelp_symt)("Adding public symbol %s:%s {addr = 0x%lx - 0x%lx (size = 0x%x)}\n",
+    TRACE_(dbghelp_symt)("Adding public symbol %s:" FUNCTION_NAME_FORMAT " {addr = 0x%lx - 0x%lx (size = 0x%x)}\n",
                          debugstr_w(module->module.ModuleName), name, address, address + size, size);
     if ((dbghelp_options & SYMOPT_AUTO_PUBLICS) &&
         symt_find_nearest(module, address) != NULL)
@@ -293,7 +293,7 @@
     struct symt_function*       sym;
     struct symt**               p;
 
-    TRACE_(dbghelp_symt)("Adding global function %s:%s @%lx-%lx\n",
+    TRACE_(dbghelp_symt)("Adding global function %s:" FUNCTION_NAME_FORMAT " @%lx-%lx\n",
                          debugstr_w(module->module.ModuleName), name, addr, addr + size - 1);
 
     assert(!sig_type || sig_type->tag == SymTagFunctionType);
@@ -327,7 +327,7 @@
 
     if (func == NULL || !(dbghelp_options & SYMOPT_LOAD_LINES)) return;
 
-    TRACE_(dbghelp_symt)("(%p)%s:%lx %s:%u\n", 
+    TRACE_(dbghelp_symt)("(%p)" FUNCTION_NAME_FORMAT ":%lx %s:%u\n", 
                          func, func->hash_elt.name, offset, 
                          source_get(module, source_idx), line_num);
 
@@ -380,7 +380,7 @@
     struct symt_data*   locsym;
     struct symt**       p;
 
-    TRACE_(dbghelp_symt)("Adding local symbol (%s:%s): %s %p\n",
+    TRACE_(dbghelp_symt)("Adding local symbol (%s:" FUNCTION_NAME_FORMAT "): %s %p\n",
                          debugstr_w(module->module.ModuleName), func->hash_elt.name,
                          name, type);