Re: additional dxdiagn functions

Hi Rob,

Thanks once again for the great work. Keep it up!

As for builtin_containers_dx9 - yeah, it would be good if we added 
values that we need (I guess one option would be to write a program 
that extracts all of the windows values into that file.. then we could 
run that with each new dx release. I guess the only problem there would 
be we will need to customise some of the values for WineX (I guess 
driver names and all that, and some features that we don't implement we 
shouldn't report as implementing).  But yeah, it would be useful to 
have such a program).  You may as well send a patch for the 
DxDiag_DirectSound.DxDiag_SoundDevices entry if you have it in your 
tree.

As for make_builtins.py - yep it is probably rather dodgy.. My python 
skills aren't that great, and it was just one of those very fast jobs 
:).  If you want to send a patch - go ahead :).

Once again, I'll review the patch and check it in on Monday, when I 
return to work (officially ;p).

Thanks,

David

--
David Hammerton
WineX developer
TransGaming Technologies
Bus: +1 416 979 9900 x329
Fax: +1 416 979 9908
[email protected]
http://www.transgaming.com
*Let the Games Begin*

On 2-Jan-04, at 11:45 PM, Rob Crittenden wrote:

> Here is a newer patch that has an additional feature. In Windows you 
> can
> fetch a container one node at a time (fetch root->a, then a->b, then 
> a->b->c)
> or you can fetch c directly by requesting "a.b.c". This new patch 
> allows
> this. It is a little ugly because there doesn't seem to be a strtokW()
> function so I have to use a strchrW() and some add'l string 
> manipulation
> instead.
>
> BTW, I'm also testing this with the BugReport.exe that ships with Max
> Payne 2. It was here that I found a request for
> "DxDiag_DirectSound.DxDiag_SoundDevices" that wasn't working properly.
>
> I wonder how whether it's worth it to add some boilerplate values to
> builtin_containers_dx9 to beef up the output of this program. In any 
> case,
> make_builtins.py is a bit limiting because of the way it names 
> variables.
> It doesn't support duplicate Container names. A patch for that may be
> forthcoming if there is interest.
>
> rob
>
> On Wed, 31 Dec 2003, Rob Crittenden wrote:
>> Ok, both unified diffs attached.
>>
>> rob
>>
>> On Wed, 31 Dec 2003, David Hammerton wrote:
>>> Hi Rob,
>>>
>>> Thanks for that!
>>>
>>> However - perhaps you could send the diff again as a unified diff (as
>>> well as your previous email).
>>>
>>> Unified diffs, created with 'cvs diff -u blah' instead of 'cvs diff
>>> blah' give more context to the changes.
>>>
>>> I'll review this on monday and commit it.
>>>
>>> Thanks again, and good work.
>>>
>>> David
>>>
>>> --
>>> David Hammerton
>>> WineX developer
>>> TransGaming Technologies
>>> Bus: +1 416 979 9900 x329
>>> Fax: +1 416 979 9908
>>> [email protected]
>>> http://www.transgaming.com
>>> *Let the Games Begin*
>>>
>>> On 31-Dec-03, at 11:18 AM, Rob Crittenden wrote:
>>>
>>>> <container.diff>
>>>
>>
> <container.diff2>