Re: joystick GetDeviceData patch

Ove Kaaven <[email protected]>
Newsgroups gmane.comp.emulators.winex.devel
Organization TransGaming Technologies Inc
Message-ID <1080638441.16693.23.camel@renegade>
The device.c part of this patch is probably not supposed be included.
The rest seems OK, except for a couple of things.

1. I'm wondering if the overflow flag really should be cleared when the
app is just peeking with DIGDD_PEEK now? You had it differently in your
previous version of the patch?

2. You seem to be removing the joy_polldev() call from GetDeviceData. I
don't think you should. For Linux 2.2, 2.4, and 2.6, the device is not
really a polled device, so we do not specify the DIDOI_POLLED flag.
There's a chance some games may actually honor this flag properly, by
not calling Poll when it's absent, and these would not work if you
remove the call.

By the way, there's a bug in joy_polldev, where the GEN_EVENT macro is
fed the original dwData from the device driver, instead of the
range-adjusted value (dwOut) which was written to
This->buffer+odf->dwOfs. Feel free to fix it. It could even be related
to your axis problem.
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.