Re: DirectPlay8Peer_Close stub patch

David Hammerton <[email protected]>
Newsgroups gmane.comp.emulators.winex.devel
Message-ID <[email protected]>
Clarence.

I've checked in a modified patch to our internal tree, it may get 
merged over soon.

Thanks very much for sending this in!

Some comments are below.

Cheers,
David

>
> +HRESULT WINAPI DirectPlay8Peer_Close(const DWORD dwFlags)

That is missing an argument, it should be 
DirectPlay8Peer_Close(PDIRECTPLAY8PEER iface, const DWORD dwFlags)

> +    FIXME("(0x%08lx): stub - SPARR \n", dwFlags);

I changed this to represent the debug flag. Also no need to put your 
name on a small fixme like that :).

> -    (void*)0xdead2019, /* Close */
> +    DirectPlay8Peer_Close,
> +//    (void*)0xdead2019, /* Close */

No need to comment it out, replacing is fine (and we only use c style 
comments, not C++ comments like //)

> -    FIXME("(%p)->(%08lx\n): stub\n", iface, dwFlags);
> +    FIXME("(%p)->(%08lx): stub\n", iface, dwFlags);

Thanks!

--
David Hammerton
WineX developer
TransGaming Technologies
Mobile: +61 439 610 116
[email protected]
http://www.transgaming.com
*Let the Games Begin*
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.