Re: Re: Complex Surfaces patch

tor, 12.08.2004 kl. 06.39 skrev Marius Grigoriu:
> Here is the new patch that follows the windows behavior. X11 licensed.

Here are my concerns with the patch:

* Indentation is wrong.
* You're using log(). I wouldn't feel comfortable using floating point
for computing something as exact as mipmap level counts. We use integer
techniques elsewhere, e.g. dlls/d3d8/texture.c.
* The role of DDSCAPS_COMPLEX is not well-proven. It is my belief that
this flag is necessary to create a mipmap chain, but has nothing to do
with the mipmap count. Perhaps you could check that, i.e., see if you
can create a mipmap chain *with* DDSD_MIPMAPCOUNT and a count, but
without DDSCAPS_COMPLEX... if I've guessed right, this should fail, and
if so, there's no reason to check for DDSCAPS_COMPLEX like this.