Re: Re: Complex Surfaces patch

ons, 18.08.2004 kl. 18.26 skrev Marius Grigoriu:
> Without complex and a mipmap count, DDERR_INVALIDCAPS

One thing I'm curious about here: what if the mipmap count is 1? Does it
still return error in this case?

> Only then the the size of the texture determins the mipmap count.

I think this comes from Windows using a different code path if COMPLEX
is set, but since our code isn't currently structured that way, I guess
you're right that we do need to check for COMPLEX here.

> About returning various errors based on invalid combinations of settings 
> in the caps, do you guys care about that?

It depends. Since the goal of Cedega is to run existing, released games
that already run well on Windows, it means that they really, really
rarely try to do something Windows would fail on, and thus we haven't
usually needed to explicitly check for bad things. A bit of laziness
there, I guess. If you want to check for errors, though, you certainly
can, it's not like it's *against* policy to check for errors. And it's
never a bad idea to do so after checking Windows behaviour, so that the
results of that checking is codified in the source, and not just
forgotten.