Re: Re: Complex Surfaces patch
Marius Grigoriu <[email protected]> Thu, 19 Aug 2004 18:12:07 -0400
| Newsgroups | gmane.comp.emulators.winex.devel |
|---|---|
| Message-ID | <[email protected]> |
Ove Kaaven wrote: >ons, 18.08.2004 kl. 18.26 skrev Marius Grigoriu: > > >>Without complex and a mipmap count, DDERR_INVALIDCAPS >> >> > >One thing I'm curious about here: what if the mipmap count is 1? Does it >still return error in this case? > > > Yes, same error. So it looks like complex is required to have a mipmap count. Setting complex and count=1 creates a chain of 1, just like not setting the count and complex flag. >>Only then the the size of the texture determins the mipmap count. >> >> > >I think this comes from Windows using a different code path if COMPLEX >is set, but since our code isn't currently structured that way, I guess >you're right that we do need to check for COMPLEX here. > > > So aside from fixing the indentation and log thing, is there anything else you want me to do before the patch can be merged?