Re: [PATCH]hotkey for mousegrab

tir, 12,.04.2005 kl. 23.43 +0200, skrev Fabian Bieler:
> This is a small hack to disable and re-enable DXGrab via Ctrl-F9.

Nice, but there are a few things.

* The variable "want_grab" was meant to control whether to regrab the
mouse when focus is restored. It would be cleaner if you made sure this
remained false when grabbing is suppressed the same way it remains false
when DXGrab is disabled.

* Ctrl-F9 may be used by some games. Preferably the keystroke should be
configurable somehow. Perhaps XStringToKeysym() can be used for that.

* You mention Ctrl-F11 is the config patch, but don't implement it. You
should probably not mention it then.