Xen Security Advisory 118 - arm: vgic: incorrect rate limiting of guest triggered logging
Xen.org security team <[email protected]>
| Newsgroups | gmane.comp.emulators.xen.announce |
|---|---|
| Message-ID | <E1YGn47-0001DT-OP__32121.4197356769$1422530773$gmane$org@xenbits.xen.org> |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Xen Security Advisory XSA-118
arm: vgic: incorrect rate limiting of guest triggered logging
ISSUE DESCRIPTION
=================
On ARM systems the code which deals with virtualising the GIC
distributor would, under various circumstances, log messages on a
guest accessible code path without appropriate rate limiting.
IMPACT
======
A malicious guest could cause repeated logging to the hypervisor
console, leading to a Denial of Service attack.
VULNERABLE SYSTEMS
==================
Xen 4.4 and later systems running on ARM hardware are vulnerable.
x86 systems are not affected.
MITIGATION
==========
The problematic log messages are issued with priority Warning.
Therefore they can be rate limited by adding "loglvl=error/warning" to the
hypervisor command line or suppressed entirely by adding "loglvl=error".
NOTE REGARDING LACK OF EMBARGO
==============================
This bug was publicly reported on xen-devel, before it was appreciated
that there was a security problem.
CREDITS
=======
This issue was discovered by Julien Grall.
RESOLUTION
==========
Applying the appropriate attached patch(es) resolves this issue.
xsa118-unstable-4.5-{1,2}.patch xen-unstable, Xen 4.5.x
xsa118-4.4.patch Xen 4.4.x
$ sha256sum xsa118*.patch
5741cfe408273bd80e1a03c21a5650f963d7103fd022c688730f55dcf5373433 xsa118-4.4.patch
ee24a4c5e12b67d7539f08b644080c87797f31b4402215cd4efbbc6114bffc25 xsa118-4.5-unstable-1.patch
bd532e3cd535fcdea51f43631a519012baff068cb62d2205fc25f2c823f031eb xsa118-4.5-unstable-2.patch
$
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
iQEcBAEBAgAGBQJUyhXoAAoJEIP+FMlX6CvZIWsH/2cK4jijgzepEboZAyIl2E8f
wWMaF6Jr28YfQz8Zcpwi4GY9BecBjm2ZUuvuHS/yPGBIvriOiZXjMtlchd3FBhjw
CTvCasqFX6DYizduAPBcph/vY2LoiYn/i74+M55I6u5g8WL/o7p3Ea3UXKg8ZdgB
PdQnLJSi4iqbO6mfdgw3lb5gfVk/DUh0rW87CoOhdPNJrQWlw9zTpfjIvrGzIDXJ
jV5eW8mBhfTE8TfuJ2cFgMZgoob709EduJ8wgLqOPMAmn1HCC/MNNtEiZhliw2yD
WQePLlXXvwXxNhHP6Ge/698unV4zPDvlCxTYjBOsZWPC1ITVhMHZ1+j3z0mXO0U=
=2kMW
-----END PGP SIGNATURE-----
_______________________________________________
Xen-announce mailing list
[email protected]
http://lists.xen.org/xen-announce
xsa118-4.4.patch
(application/octet-stream, 4.7 KB)
From 172cf0489b504b35c7c1666fb7d015006976c4e7 Mon Sep 17 00:00:00 2001 From: Julien Grall <[email protected]> Date: Mon, 19 Jan 2015 12:59:42 +0000 Subject: [PATCH] xen/arm: vgic: message in the emulation code should be rate-limited printk is not rated-limited by default. Therefore a malicious guest may be able to flood the Xen console. If we use gdprintk, unecessary information will be printed such as the filename and the line. Instead use XENLOG_G_ERR combine with %pv. Signed-off-by: Julien Grall <[email protected]> --- xen/arch/arm/vgic.c | 40 +++++++++++++++++++++++----------------- 1 file changed, 23 insertions(+), 17 deletions(-) diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c index 8d1b79e..b2262c6 100644 --- a/xen/arch/arm/vgic.c +++ b/xen/arch/arm/vgic.c @@ -332,7 +332,7 @@ static int vgic_distr_mmio_read(struct vcpu *v, mmio_info_t *info) case GICD_ICPIDR2: if ( dabt.size != 2 ) goto bad_width; - printk("vGICD: unhandled read from ICPIDR2\n"); + printk(XENLOG_G_ERR "%pv: vGICD: unhandled read from ICPIDR2\n", v); return 0; /* Implementation defined -- read as zero */ @@ -349,14 +349,14 @@ static int vgic_distr_mmio_read(struct vcpu *v, mmio_info_t *info) goto read_as_zero; default: - printk("vGICD: unhandled read r%d offset %#08x\n", - dabt.reg, offset); + printk(XENLOG_G_ERR "%pv: vGICD: unhandled read r%d offset %#08x\n", + v, dabt.reg, offset); return 0; } bad_width: - printk("vGICD: bad read width %d r%d offset %#08x\n", - dabt.size, dabt.reg, offset); + printk(XENLOG_G_ERR "%pv: vGICD: bad read width %d r%d offset %#08x\n", + v, dabt.size, dabt.reg, offset); domain_crash_synchronous(); return 0; @@ -523,14 +523,16 @@ static int vgic_distr_mmio_write(struct vcpu *v, mmio_info_t *info) case GICD_ISPENDR ... GICD_ISPENDRN: if ( dabt.size != 0 && dabt.size != 2 ) goto bad_width; - printk("vGICD: unhandled %s write %#"PRIregister" to ISPENDR%d\n", - dabt.size ? "word" : "byte", *r, gicd_reg - GICD_ISPENDR); + printk(XENLOG_G_ERR + "%pv: vGICD: unhandled %s write %#"PRIregister" to ISPENDR%d\n", + v, dabt.size ? "word" : "byte", *r, gicd_reg - GICD_ISPENDR); return 0; case GICD_ICPENDR ... GICD_ICPENDRN: if ( dabt.size != 0 && dabt.size != 2 ) goto bad_width; - printk("vGICD: unhandled %s write %#"PRIregister" to ICPENDR%d\n", - dabt.size ? "word" : "byte", *r, gicd_reg - GICD_ICPENDR); + printk(XENLOG_G_ERR + "%pv: vGICD: unhandled %s write %#"PRIregister" to ICPENDR%d\n", + v, dabt.size ? "word" : "byte", *r, gicd_reg - GICD_ICPENDR); return 0; case GICD_ISACTIVER ... GICD_ISACTIVERN: @@ -606,14 +608,16 @@ static int vgic_distr_mmio_write(struct vcpu *v, mmio_info_t *info) case GICD_CPENDSGIR ... GICD_CPENDSGIRN: if ( dabt.size != 0 && dabt.size != 2 ) goto bad_width; - printk("vGICD: unhandled %s write %#"PRIregister" to ICPENDSGIR%d\n", - dabt.size ? "word" : "byte", *r, gicd_reg - GICD_CPENDSGIR); + printk(XENLOG_G_ERR + "%pv: vGICD: unhandled %s write %#"PRIregister" to ICPENDSGIR%d\n", + v, dabt.size ? "word" : "byte", *r, gicd_reg - GICD_CPENDSGIR); return 0; case GICD_SPENDSGIR ... GICD_SPENDSGIRN: if ( dabt.size != 0 && dabt.size != 2 ) goto bad_width; - printk("vGICD: unhandled %s write %#"PRIregister" to ISPENDSGIR%d\n", - dabt.size ? "word" : "byte", *r, gicd_reg - GICD_SPENDSGIR); + printk(XENLOG_G_ERR + "%pv: vGICD: unhandled %s write %#"PRIregister" to ISPENDSGIR%d\n", + v, dabt.size ? "word" : "byte", *r, gicd_reg - GICD_SPENDSGIR); return 0; /* Implementation defined -- write ignored */ @@ -638,14 +642,16 @@ static int vgic_distr_mmio_write(struct vcpu *v, mmio_info_t *info) goto write_ignore; default: - printk("vGICD: unhandled write r%d=%"PRIregister" offset %#08x\n", - dabt.reg, *r, offset); + printk(XENLOG_G_ERR + "%pv: vGICD: unhandled write r%d=%"PRIregister" offset %#08x\n", + v, dabt.reg, *r, offset); return 0; } bad_width: - printk("vGICD: bad write width %d r%d=%"PRIregister" offset %#08x\n", - dabt.size, dabt.reg, *r, offset); + printk(XENLOG_G_ERR + "%pv: vGICD: bad write width %d r%d=%"PRIregister" offset %#08x\n", + v, dabt.size, dabt.reg, *r, offset); domain_crash_synchronous(); return 0; -- 2.1.4
xsa118-4.5-unstable-1.patch
(application/octet-stream, 10 KB)
From e698f4ab05a710e4463317ea978d426d43107e27 Mon Sep 17 00:00:00 2001 From: Julien Grall <[email protected]> Date: Mon, 19 Jan 2015 14:01:09 +0000 Subject: [PATCH 1/2] xen/arm: vgic-v3: message in the emulation code should be rate-limited printk by default is not rate-limited by default. Therefore a malicious guest may be able to flood the Xen console. If we use gdprintk, unnecessary information will be printed such as the filename and the line. Instead use XENLOG_G_{ERR,DEBUG} combine with %pv. Also remove the vGICv3 prefix which is not neccessary and update some message which were wrong. Signed-off-by: Julien Grall <[email protected]> --- xen/arch/arm/vgic-v3.c | 109 +++++++++++++++++++++++++++---------------------- 1 file changed, 61 insertions(+), 48 deletions(-) diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c index ae4482c..bece189 100644 --- a/xen/arch/arm/vgic-v3.c +++ b/xen/arch/arm/vgic-v3.c @@ -168,13 +168,14 @@ static int __vgic_v3_rdistr_rd_mmio_read(struct vcpu *v, mmio_info_t *info, /* Reserved0 */ goto read_as_zero; default: - printk("vGICv3: vGICR: read r%d offset %#08x\n not found", - dabt.reg, gicr_reg); + printk(XENLOG_G_ERR + "%pv: vGICR: read r%d offset %#08x\n not found", + v, dabt.reg, gicr_reg); return 0; } bad_width: - printk("vGICv3: vGICR: bad read width %d r%d offset %#08x\n", - dabt.size, dabt.reg, gicr_reg); + printk(XENLOG_G_ERR "%pv vGICR: bad read width %d r%d offset %#08x\n", + v, dabt.size, dabt.reg, gicr_reg); domain_crash_synchronous(); return 0; @@ -244,12 +245,14 @@ static int __vgic_v3_rdistr_rd_mmio_write(struct vcpu *v, mmio_info_t *info, /* RO */ goto write_ignore; default: - printk("vGICR: write r%d offset %#08x\n not found", dabt.reg, gicr_reg); + printk(XENLOG_G_ERR "%pv: vGICR: write r%d offset %#08x\n not found", + v, dabt.reg, gicr_reg); return 0; } bad_width: - printk("vGICR: bad write width %d r%d=%"PRIregister" offset %#08x\n", - dabt.size, dabt.reg, *r, gicr_reg); + printk(XENLOG_G_ERR + "%pv: vGICR: bad write width %d r%d=%"PRIregister" offset %#08x\n", + v, dabt.size, dabt.reg, *r, gicr_reg); domain_crash_synchronous(); return 0; @@ -345,15 +348,16 @@ static int __vgic_v3_distr_common_mmio_read(struct vcpu *v, mmio_info_t *info, vgic_unlock_rank(v, rank, flags); return 1; default: - printk("vGICv3: vGICD/vGICR: unhandled read r%d offset %#08x\n", - dabt.reg, reg); + printk(XENLOG_G_ERR + "%pv: vGICD/vGICR: unhandled read r%d offset %#08x\n", + v, dabt.reg, reg); return 0; } bad_width: - dprintk(XENLOG_ERR, - "vGICv3: vGICD/vGICR: bad read width %d r%d offset %#08x\n", - dabt.size, dabt.reg, reg); + printk(XENLOG_G_ERR + "%pv: vGICD/vGICR: bad read width %d r%d offset %#08x\n", + v, dabt.size, dabt.reg, reg); domain_crash_synchronous(); return 0; @@ -458,15 +462,16 @@ static int __vgic_v3_distr_common_mmio_write(struct vcpu *v, mmio_info_t *info, vgic_unlock_rank(v, rank, flags); return 1; default: - printk("vGICv3: vGICD/vGICR: unhandled write r%d " - "=%"PRIregister" offset %#08x\n", dabt.reg, *r, reg); + printk(XENLOG_G_ERR + "%pv: vGICD/vGICR: unhandled write r%d=%"PRIregister" offset %#08x\n", + v, dabt.reg, *r, reg); return 0; } bad_width: - dprintk(XENLOG_ERR, - "vGICv3: vGICD/vGICR: bad write width %d r%d=%"PRIregister" " - "offset %#08x\n", dabt.size, dabt.reg, *r, reg); + printk(XENLOG_G_ERR + "%pv: vGICD/vGICR: bad write width %d r%d=%"PRIregister" offset %#08x\n", + v, dabt.size, dabt.reg, *r, reg); domain_crash_synchronous(); return 0; @@ -521,13 +526,14 @@ static int vgic_v3_rdistr_sgi_mmio_read(struct vcpu *v, mmio_info_t *info, if ( dabt.size != DABT_WORD ) goto bad_width; return 1; default: - printk("vGICv3: vGICR: read r%d offset %#08x\n not found", - dabt.reg, gicr_reg); + printk(XENLOG_G_ERR + "%pv: vGICR: SGI: read r%d offset %#08x\n not found", + v, dabt.reg, gicr_reg); return 0; } bad_width: - printk("vGICv3: vGICR: bad read width %d r%d offset %#08x\n", - dabt.size, dabt.reg, gicr_reg); + printk(XENLOG_G_ERR "%pv: vGICR: SGI: bad read width %d r%d offset %#08x\n", + v, dabt.size, dabt.reg, gicr_reg); domain_crash_synchronous(); return 0; @@ -585,14 +591,16 @@ static int vgic_v3_rdistr_sgi_mmio_write(struct vcpu *v, mmio_info_t *info, /* We do not implement security extensions for guests, write ignore */ goto write_ignore; default: - printk("vGICv3: vGICR SGI: write r%d offset %#08x\n not found", - dabt.reg, gicr_reg); + printk(XENLOG_G_ERR + "%pv: vGICR: SGI: write r%d offset %#08x\n not found", + v, dabt.reg, gicr_reg); return 0; } bad_width: - printk("vGICR SGI: bad write width %d r%d=%"PRIregister" offset %#08x\n", - dabt.size, dabt.reg, *r, gicr_reg); + printk(XENLOG_G_ERR + "%pv: vGICR: SGI: bad write width %d r%d=%"PRIregister" offset %#08x\n", + v, dabt.size, dabt.reg, *r, gicr_reg); domain_crash_synchronous(); return 0; @@ -618,9 +626,9 @@ static int vgic_v3_rdistr_mmio_read(struct vcpu *v, mmio_info_t *info) else if ( (offset >= SZ_64K) && (offset < 2 * SZ_64K) ) return vgic_v3_rdistr_sgi_mmio_read(v, info, (offset - SZ_64K)); else - gdprintk(XENLOG_WARNING, - "vGICv3: vGICR: unknown gpa read address %"PRIpaddr"\n", - info->gpa); + printk(XENLOG_G_WARNING + "%pv: vGICR: unknown gpa read address %"PRIpaddr"\n", + v, info->gpa); return 0; } @@ -642,9 +650,9 @@ static int vgic_v3_rdistr_mmio_write(struct vcpu *v, mmio_info_t *info) else if ( (offset >= SZ_64K) && (offset < 2 * SZ_64K) ) return vgic_v3_rdistr_sgi_mmio_write(v, info, (offset - SZ_64K)); else - gdprintk(XENLOG_WARNING, - "vGICV3: vGICR: unknown gpa write address %"PRIpaddr"\n", - info->gpa); + printk(XENLOG_G_WARNING + "%pv: vGICR: unknown gpa write address %"PRIpaddr"\n", + v, info->gpa); return 0; } @@ -770,18 +778,19 @@ static int vgic_v3_distr_mmio_read(struct vcpu *v, mmio_info_t *info) case 0xf30 ... 0x5fcc: case 0x8000 ... 0xbfcc: /* These are reserved register addresses */ - printk("vGICv3: vGICD: read unknown 0x00c .. 0xfcc r%d offset %#08x\n", - dabt.reg, gicd_reg); + printk(XENLOG_G_DEBUG + "%pv: vGICD: RAZ on reserved register offset %#08x\n", + v, gicd_reg); goto read_as_zero; default: - printk("vGICv3: vGICD: unhandled read r%d offset %#08x\n", - dabt.reg, gicd_reg); + printk(XENLOG_G_ERR "%pv: vGICD: unhandled read r%d offset %#08x\n", + v, dabt.reg, gicd_reg); return 0; } bad_width: - dprintk(XENLOG_ERR, "vGICv3: vGICD: bad read width %d r%d offset %#08x\n", - dabt.size, dabt.reg, gicd_reg); + printk(XENLOG_G_ERR "%pv: vGICD: bad read width %d r%d offset %#08x\n", + v, dabt.size, dabt.reg, gicd_reg); domain_crash_synchronous(); return 0; @@ -840,8 +849,9 @@ static int vgic_v3_distr_mmio_write(struct vcpu *v, mmio_info_t *info) case 0x020 ... 0x03c: case 0xc000 ... 0xffcc: /* Implementation defined -- write ignored */ - printk("vGICv3: vGICD: write unknown 0x020 - 0x03c r%d offset %#08x\n", - dabt.reg, gicd_reg); + printk(XENLOG_G_DEBUG + "%pv: vGICD: WI on implementation defined register offset %#08x\n", + v, gicd_reg); goto write_ignore; case GICD_IGROUPR ... GICD_IGROUPRN: case GICD_ISENABLER ... GICD_ISENABLERN: @@ -885,8 +895,9 @@ static int vgic_v3_distr_mmio_write(struct vcpu *v, mmio_info_t *info) new_target = new_irouter & MPIDR_AFF0_MASK; if ( new_target >= v->domain->max_vcpus ) { - printk("vGICv3: vGICD: wrong irouter at offset %#08x\n val 0x%lx vcpu %x", - gicd_reg, new_target, v->domain->max_vcpus); + printk(XENLOG_G_DEBUG + "%pv: vGICD: wrong irouter at offset %#08x\n val 0x%lx vcpu %x", + v, gicd_reg, new_target, v->domain->max_vcpus); vgic_unlock_rank(v, rank, flags); return 0; } @@ -926,19 +937,21 @@ static int vgic_v3_distr_mmio_write(struct vcpu *v, mmio_info_t *info) case 0xf30 ... 0x5fcc: case 0x8000 ... 0xbfcc: /* Reserved register addresses */ - printk("vGICv3: vGICD: write unknown 0x00c 0xfcc r%d offset %#08x\n", - dabt.reg, gicd_reg); + printk(XENLOG_G_DEBUG + "%pv: vGICD: write unknown 0x00c 0xfcc r%d offset %#08x\n", + v, dabt.reg, gicd_reg); goto write_ignore; default: - printk("vGICv3: vGICD: unhandled write r%d=%"PRIregister" " - "offset %#08x\n", dabt.reg, *r, gicd_reg); + printk(XENLOG_G_ERR + "%pv: vGICD: unhandled write r%d=%"PRIregister" offset %#08x\n", + v, dabt.reg, *r, gicd_reg); return 0; } bad_width: - dprintk(XENLOG_ERR, - "VGICv3: vGICD: bad write width %d r%d=%"PRIregister" " - "offset %#08x\n", dabt.size, dabt.reg, *r, gicd_reg); + printk(XENLOG_G_ERR + "%pv: vGICD: bad write width %d r%d=%"PRIregister" offset %#08x\n", + v, dabt.size, dabt.reg, *r, gicd_reg); domain_crash_synchronous(); return 0; -- 2.1.4
xsa118-4.5-unstable-2.patch
(application/octet-stream, 4.8 KB)
From e8fa469595e29b2dbe6dde3a77ee2ea2d9e93283 Mon Sep 17 00:00:00 2001 From: Julien Grall <[email protected]> Date: Mon, 19 Jan 2015 12:59:42 +0000 Subject: [PATCH 2/2] xen/arm: vgic-v2: message in the emulation code should be rate-limited printk is not rated-limited by default. Therefore a malicious guest may be able to flood the Xen console. If we use gdprintk, unecessary information will be printed such as the filename and the line. Instead use XENLOG_G_ERR combine with %pv. Signed-off-by: Julien Grall <[email protected]> --- xen/arch/arm/vgic-v2.c | 40 +++++++++++++++++++++++----------------- 1 file changed, 23 insertions(+), 17 deletions(-) diff --git a/xen/arch/arm/vgic-v2.c b/xen/arch/arm/vgic-v2.c index 9dc9a20..3b87f54 100644 --- a/xen/arch/arm/vgic-v2.c +++ b/xen/arch/arm/vgic-v2.c @@ -198,7 +198,7 @@ static int vgic_v2_distr_mmio_read(struct vcpu *v, mmio_info_t *info) case GICD_ICPIDR2: if ( dabt.size != DABT_WORD ) goto bad_width; - printk("vGICD: unhandled read from ICPIDR2\n"); + printk(XENLOG_G_ERR "%pv: vGICD: unhandled read from ICPIDR2\n", v); return 0; /* Implementation defined -- read as zero */ @@ -215,14 +215,14 @@ static int vgic_v2_distr_mmio_read(struct vcpu *v, mmio_info_t *info) goto read_as_zero; default: - printk("vGICD: unhandled read r%d offset %#08x\n", - dabt.reg, gicd_reg); + printk(XENLOG_G_ERR "%pv: vGICD: unhandled read r%d offset %#08x\n", + v, dabt.reg, gicd_reg); return 0; } bad_width: - printk("vGICD: bad read width %d r%d offset %#08x\n", - dabt.size, dabt.reg, gicd_reg); + printk(XENLOG_G_ERR "%pv: vGICD: bad read width %d r%d offset %#08x\n", + v, dabt.size, dabt.reg, gicd_reg); domain_crash_synchronous(); return 0; @@ -331,14 +331,16 @@ static int vgic_v2_distr_mmio_write(struct vcpu *v, mmio_info_t *info) case GICD_ISPENDR ... GICD_ISPENDRN: if ( dabt.size != DABT_BYTE && dabt.size != DABT_WORD ) goto bad_width; - printk("vGICD: unhandled %s write %#"PRIregister" to ISPENDR%d\n", - dabt.size ? "word" : "byte", *r, gicd_reg - GICD_ISPENDR); + printk(XENLOG_G_ERR + "%pv: vGICD: unhandled %s write %#"PRIregister" to ISPENDR%d\n", + v, dabt.size ? "word" : "byte", *r, gicd_reg - GICD_ISPENDR); return 0; case GICD_ICPENDR ... GICD_ICPENDRN: if ( dabt.size != DABT_BYTE && dabt.size != DABT_WORD ) goto bad_width; - printk("vGICD: unhandled %s write %#"PRIregister" to ICPENDR%d\n", - dabt.size ? "word" : "byte", *r, gicd_reg - GICD_ICPENDR); + printk(XENLOG_G_ERR + "%pv: vGICD: unhandled %s write %#"PRIregister" to ICPENDR%d\n", + v, dabt.size ? "word" : "byte", *r, gicd_reg - GICD_ICPENDR); return 0; case GICD_ISACTIVER ... GICD_ISACTIVERN: @@ -457,14 +459,16 @@ static int vgic_v2_distr_mmio_write(struct vcpu *v, mmio_info_t *info) case GICD_CPENDSGIR ... GICD_CPENDSGIRN: if ( dabt.size != DABT_BYTE && dabt.size != DABT_WORD ) goto bad_width; - printk("vGICD: unhandled %s write %#"PRIregister" to ICPENDSGIR%d\n", - dabt.size ? "word" : "byte", *r, gicd_reg - GICD_CPENDSGIR); + printk(XENLOG_G_ERR + "%pv: vGICD: unhandled %s write %#"PRIregister" to ICPENDSGIR%d\n", + v, dabt.size ? "word" : "byte", *r, gicd_reg - GICD_CPENDSGIR); return 0; case GICD_SPENDSGIR ... GICD_SPENDSGIRN: if ( dabt.size != DABT_BYTE && dabt.size != DABT_WORD ) goto bad_width; - printk("vGICD: unhandled %s write %#"PRIregister" to ISPENDSGIR%d\n", - dabt.size ? "word" : "byte", *r, gicd_reg - GICD_SPENDSGIR); + printk(XENLOG_G_ERR + "%pv: vGICD: unhandled %s write %#"PRIregister" to ISPENDSGIR%d\n", + v, dabt.size ? "word" : "byte", *r, gicd_reg - GICD_SPENDSGIR); return 0; /* Implementation defined -- write ignored */ @@ -489,14 +493,16 @@ static int vgic_v2_distr_mmio_write(struct vcpu *v, mmio_info_t *info) goto write_ignore; default: - printk("vGICD: unhandled write r%d=%"PRIregister" offset %#08x\n", - dabt.reg, *r, gicd_reg); + printk(XENLOG_G_ERR + "%pv: vGICD: unhandled write r%d=%"PRIregister" offset %#08x\n", + v, dabt.reg, *r, gicd_reg); return 0; } bad_width: - printk("vGICD: bad write width %d r%d=%"PRIregister" offset %#08x\n", - dabt.size, dabt.reg, *r, gicd_reg); + printk(XENLOG_G_ERR + "%pv: vGICD: bad write width %d r%d=%"PRIregister" offset %#08x\n", + v, dabt.size, dabt.reg, *r, gicd_reg); domain_crash_synchronous(); return 0; -- 2.1.4