Re: [PATCH 7/7] gnttab: unreachable code when GNTTAB_MAX_VERSION < 2
Jan Beulich <[email protected]> Tue, 28 Jul 2026 17:42:03 +0200
| Newsgroups | gmane.comp.emulators.xen.devel |
|---|---|
| Message-ID | <[email protected]> |
On 28.07.2026 17:40, Nicola Vetrini wrote: > On 2026-07-28 15:53, Jan Beulich wrote: >> I'm surprised Eclair doesn't spot the large chunks of unreachable code >> on >> Arm, i.e. violations of Misra C:2012 rule 2.1. >> >> Signed-off-by: Jan Beulich <[email protected]> >> --- >> This pretty certainly isn't dealing with everything. For example, with >> another helper the gt_version field could likely also become >> conditional. >> With some more effort the nr_status_frames field similarly could become >> conditional. >> > [...] > > Hard to judge only looking at the diff. Is this code unreachable in the > arm64-allcode analysis configuration as well? Arm uniformly has #define GNTTAB_MAX_VERSION 1 so all gnttab-v2 code is unreachable there, no matter what configuration. Jan