Re: [PATCH 2/2] tools/ocaml: Fill arch_config for ARM in domain_getinfo{,list}()

On 28/07/2026 4:52 pm, Jan Beulich wrote:
> On 28.07.2026 17:48, Andrew Cooper wrote:
>> --- a/tools/ocaml/libs/xc/xenctrl_stubs.c
>> +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c
>> @@ -444,9 +444,21 @@ static value alloc_domaininfo(xc_domaininfo_t * info)
>>  
>>  	Store_field(result, 15, tmp);
>>  
>> -#if defined(__i386__) || defined(__x86_64__)
>> +#if defined(__arm__) || defined(__aarch64__)
>>  
>> -	tag = 1; /* tag x86 */
>> +	tag = 0; /* tag ARM */
>> +
>> +        /* xen_arm_arch_domainconfig */
>> +        arch_config = caml_alloc_tuple(3);
>> +        Field(arch_config, 0) = Val_int(info->arch_config.gic_version);
>> +        Field(arch_config, 1) = Val_int(info->arch_config.nr_spis);
>> +
>> +	tmp = caml_copy_int32(info->arch_config.clock_frequency);
>> +        Field(arch_config, 2) = tmp;
>> +
>> +#elif defined(__i386__) || defined(__x86_64__)
>> +
>> +        tag = 1; /* tag x86 */
>>  
>>  	/*
>>  	 * emulation_flags: x86_arch_emulation_flags list;
> I know nothing about style rules or conventions here, but simply from
> looking at the diff I came to wonder: Is this mix of tab vs space
> indentation deliberate?

No, unintentional.  I'll fix up locally.

~Andrew