Re: [PATCH 1/2] tools/ocaml: Fix crash in Xenctrl.domain_getinfo{,list} on ARM

On 28.07.2026 17:48, Andrew Cooper wrote:
> @@ -452,16 +456,17 @@ static value alloc_domaininfo(xc_domaininfo_t * info)
>  		(info->arch_config.emulation_flags);
>  
>  	/* xen_x86_arch_domainconfig */
> -	x86_arch_config = caml_alloc_tuple(1);
> -	Store_field(x86_arch_config, 0, emul_list);
> +	arch_config = caml_alloc_tuple(1);
> +	Field(arch_config, 0) = emul_list;
>  
> -	/* arch_config: arch_domainconfig */
> -	arch_config = caml_alloc_small(1, 1);
> -
> -	Store_field(arch_config, 0, x86_arch_config);
> -
> -	Store_field(result, 16, arch_config);
>  #endif
> +	if (tag < 0)
> +		caml_failwith("Unimplemented architecutre in alloc_domaininfo()");

As I now ended up looking here as well (to determine whether this series will
want backporting): s/architecutre/architecture/ .

As to backporting: Both patches may want to have Fixes: tags?

Jan