Re: [PATCH 1/2] tools/ocaml: Fix crash in Xenctrl.domain_getinfo{,list} on ARM

Teddy Astie <[email protected]> Wed, 29 Jul 2026 13:46:44 +0200
Newsgroups gmane.comp.emulators.xen.devel
Message-ID <1785325606.8631fc262581453bbf619ec5b2062170.19fadb2d454000e099@vates.tech>
Le 28/07/2026 à 17:49, Andrew Cooper a écrit :
> The Store_field(result, 16, arch_config) sits inside an ifdef x86, meaning
> that on other archtiectures the pointer is not filled in.  The Ocaml runtime
> then falls over a NULL pointer (really the Val_unit used to initialise
> 'result') when the layout in the heap doesn't match the type system.
> 
> Rearrange alloc_domaininfo() to avoid this.  Similarly to
> physinfo_arch_caps(), raise an exception if the architecture code hasn't
> filled in an appropriate tag.  Move the setup of arch_domainconfig to be
> common logic.
> 
> In order to simplify the addition of other architectures, remove the
> arch_config variable (resuing tmp as it's touched exactly once), and rename
> x86_arch_config to be arch_config so each architecture can fill in a suitable
> one without needing more local variables.
> 
> Reported-by: Julian Vetter <[email protected]>
> Signed-off-by: Andrew Cooper <[email protected]>

Reviewed-by: Teddy Astie <[email protected]>

I guess that requires the OCaml user side to be appropriately patched to 
not get data in the wrong order ?

Teddy
OpenPGP_0x660FA9D102CBCFD0.asc (application/pgp-keys, 2.4 KB)
-----BEGIN PGP PUBLIC KEY BLOCK-----

xsDNBGn5sK8BDACuzSrrTjpVf4ay06OYB6yY0J1PqKffihoNMtrQRZjAHxoAPC7L
TBVHV/XOZw5HJc+9R71z1JV+iYg6z3jPziGKzX8Fj3ZXlzJPmpf1PuETH3KdbvtJ
T4ny+OGntnJntUoRKRPhTirr6yNeBk/637O3CQXjtqFUPZnko8OI/o1yawIBhJJA
WicutjkkUgd28Bh6HV9EIumHtCBgn5/1A/fpm9624MMgYLsA8qjC4XsoovQvFCaO
8HEhvfzrrTZHjn/nPeB9SigxIxXW8YaTVqMdqul07o72m3eA2mf+LMu9a04FX/d4
wbxBLtELm+1jIrbtyaFZEMOLv/haSiS/Lj3btJH/EoucejoZ5SH49ksmVAmKOLkt
OaTQ8b2gEvP7iaKiIiszCCtOSRohr+2GvDsDeLvVZnlR3I+SPhHar7TPKjFz0G3D
PNolyjXywNqOAMpomSPi8lSwjAFsxOtQbcck/qRGRSNk4DAmH70pA+89MXfQXZ3q
t1Q01B1+sU0I8xsAEQEAAc0kVGVkZHkgQXN0aWUgPHRlZGR5LmFzdGllQHZhdGVz
LnRlY2g+wsENBBMBCAA3FiEEGAIew9LzHY3pdrqtZg+p0QLLz9AFAmn5sK8FCQWj
moACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRBmD6nRAsvP0ID6DACGOktArFbLKHNz
uyOVCskwfUZPla6Zpd3GZ8r61SrAKePIr2BnpgPkd0hV3bSRkRLIrgjzR2NRCzfp
0x0HfuhcYfAYPR46XHTvjaJEv99sT/vGUG1BZguYDOScSEpgSNaNlYum3RKZbMuR
OxdK8G+YHccJY8PvWSq2K2yiae2KGiAv1yjnZxug9/PtDfX8vQFUSg2w1ukRDf50
wvDohN1zUQfFtofOP2xCRsDZiHAlQ0pF+aUjXQhPeP3IdpfWc8cyRLXF06Rk46YM
YCytweGtGdHcqAfrVthl84129ZPN422k/voW0sm14gjYlGcTUwgnYlFRk2FLq0Qe
KEDcS0aj3o3EVAQCrayoGzi1pnlIKE3PRGUcUzjGVvzQ/po24gOjwba9Egr/Wmu3
MQlx/7A8zT5QBzF/n+RYdLNQ0Eu6YnUwf0Z1uieqNaon+olyIRFiLb/hCZHO6ekN
f5vrm2clHUbQAYaPQebknujoKBo6ZLHg0WM1gZS01Gz+aUpKsUfOwM0EafmwsAEM
AKiQiZa3yQMmc/h3sDbfVHPSiBA4IMI/NAB7IotzPHq1GzCpsoVILAhF/INbWjxJ
3DbVf+en3/FvdVZg2S38xtnth0njNdlVKpyxm054phKjbdoFDwaknWolS4hrddTm
etSG5/52AjtmPFtlXAk0NmLvfJnW3seXVQbgM7sW/MNXPP5UKDpkGnLhnvej+GU0
s3109sJeXT5ImVdphFs9cvyZyBT9t1PbRowv58EgV0zE4hbAeVkULAbxFV5b/ExT
jjGVHoX7CVhWxvCiTqCUoXZRkUE9C3FnkzEFRkKbYu6NCfiHfEyB3Xyg9hfdrRgj
MRq907zCof+nDtWxGz1MSEuvTj1g9GZ049Bennqzjc/Q+0ovXoK4jm+Py0FiUGUa
A6yhexficjH+kCR/xDbVnWrMhSLB4AuTBT9HjfZI6gk3uYLhoT8Pig4/eVtR2Q1w
ZIJsFToR6ofGuyECwFcs+PUXN7fmGRSiPXgjAr/zIUBdW0VWCE3OGPNqtRk2E5s6
IQARAQABwsD8BBgBCAAmFiEEGAIew9LzHY3pdrqtZg+p0QLLz9AFAmn5sLAFCQWj
moACGwwACgkQZg+p0QLLz9DncQwAg76IehTemLIfrB8T9WIBZrI4kUV7G7a4rjiV
oUiHYN5QwhnbZnsaJDlt+Ezoqy/510eo2bCSzvW5xXYPgyjcuOPwgQo1Qp764Qxy
X6rld2f2RcWkDuBHun55ZWXjby8o21ginPRwruBVYY5rVf3DV1iBu4NurUeHtyFk
/dS0XTOQi2wVUb17sW/+ybCEokdVacZGzOqP/OmwHrF8ylXlXnhQq6e3r+J+T8fu
oGJelm/CJiMwyP6cEWE8sxVqX/iqwjwUYkuOCpE+lOWSvdNHgoEkWR0RXBPQjnGm
LKbfTl/QDXLk6NP2/r9uxm2HL6Ei3QJKSEdrp+XZaVnk/OffO485NOTKwGOxyWb0
06cTMh53xPkAJFQu4Tvdj+odsHz88jqw5wfPG0BYWx0I/FspYj7N9kZR8ULR9nX0
LvpzJ/kB4NgHIUt8YtIL6ZSfM2dbF7fKzvx1UqFfvozJZwFzfEieJLXa4nlGgR6D
x9fhaZEsniw8/bYgC3igkk5YJiOa
=lUIA
-----END PGP PUBLIC KEY BLOCK-----
OpenPGP_signature.asc (application/pgp-signature, 665 B)
-----BEGIN PGP SIGNATURE-----

wsD5BAABCAAjFiEEGAIew9LzHY3pdrqtZg+p0QLLz9AFAmpp6CQFAwAAAAAACgkQZg+p0QLLz9Ci
NQwAhQ7pBiuTDDDs7BoLE7GyPuZsHOUT5il3khVByrHl+nBnfVHkf+6O3vMuJ2EGrWEqWS5/NuHx
2c/UYjXPWEAP964d78Uqj7UjCdZW69jJrrdHWynquX72gpCXuA538VVWGninocKZuiv2MYQY8ePz
kuiju9/HApgDFEyCslth+Sy8GufPKxH+ZyenowSsfMAJ+7xbKQi/V7SOeI1atFHWsdDsk9i91z3U
8u1Io0INF1KbJ4XetkDavgmWgVFb+xN40A6mw+1IpRdBqAzHfJjqYg0YfEs7n7btb3uanbom++nF
ABTMJLUNuPTV0+S9PvPSgjrIvmpuFGcAnyQTcNRylm3xXi1RuL19AyJ6oWr+evsd4xQocGid43Uj
nwm1RG0owAbcUpdIylWh3gK9/saCAAGLn306MQFYlQNXYf/LD/H7mk7k1rhy4XRfsMvniYJZF/Li
8cvyI2MSfFw/kLPgnkFkyv6ZBsvGMHX7IXDqCJkPpwn4MS69D+F8TbFqen+o
=ipYy
-----END PGP SIGNATURE-----