Re: [PATCH v2 6/8] block: add missing coroutine_fn annotations

Stefan Hajnoczi <[email protected]> Thu, 30 Jul 2026 12:08:49 -0400

Newsgroups	gmane.comp.emulators.xen.devel,gmane.comp.emulators.qemu,gmane.comp.emulators.qemu.block
Message-ID	<20260730160849.GE1442692@fedora>

On Sat, Jul 25, 2026 at 01:48:37PM +0400, Marc-André Lureau wrote:
> diff --git a/block/parallels.c b/block/parallels.c
> index 7a90fb5220b9..6f96cc4e3045 100644
> --- a/block/parallels.c
> +++ b/block/parallels.c
> @@ -142,8 +142,9 @@ static uint32_t host_cluster_index(BDRVParallelsState *s, int64_t off)
>      return off / s->cluster_size;
>  }
>  
> -static int64_t block_status(BDRVParallelsState *s, int64_t sector_num,
> -                            int nb_sectors, int *pnum)
> +static int64_t
> +block_status(BDRVParallelsState *s, int64_t sector_num,
> +             int nb_sectors, int *pnum)
>  {
>      int64_t start_off = -2, prev_end_off = -2;
>  

This hunk looks like an accidental whitespace change? This function is
not a coroutine function.

> @@ -2126,7 +2128,8 @@ fail:
>      return ret;
>  }
>  
> -static void qcow2_reopen_commit(BDRVReopenState *state)
> +static void
> +qcow2_reopen_commit(BDRVReopenState *state)

Whitespace change?

Looks good aside from these whitespace changes.

signature.asc (application/pgp-signature, 488 B)