Re: [PATCH 10/24] XSM: make .dm_op() hook dependent upon IOREQ_SERVER=y

On 7/28/26 9:17 AM, Jan Beulich wrote:
> It's unreachable / dead otherwise.
> 
> Signed-off-by: Jan Beulich <[email protected]>
> 
> --- a/xen/include/xsm/dummy.h
> +++ b/xen/include/xsm/dummy.h
> @@ -739,11 +739,13 @@ static XSM_INLINE int cf_check xsm_pmu_o
>   
>   #endif /* CONFIG_X86 */
>   
> +#ifdef CONFIG_IOREQ_SERVER
>   static XSM_INLINE int cf_check xsm_dm_op(XSM_DEFAULT_ARG struct domain *d)
>   {
>       XSM_ASSERT_ACTION(XSM_DM_PRIV);
>       return xsm_default_action(action, current->domain, d);
>   }
> +#endif
>   
>   #ifdef CONFIG_ARGO
>   static XSM_INLINE int cf_check xsm_argo_enable(const struct domain *d)
> --- a/xen/include/xsm/hooks.h
> +++ b/xen/include/xsm/hooks.h
> @@ -145,7 +145,10 @@ XSM_HOOK(int, ioport_mapping, struct dom
>   XSM_HOOK(int, pmu_op, struct domain *, unsigned int)
>   #endif /* CONFIG_X86 */
>   
> +#ifdef CONFIG_IOREQ_SERVER
>   XSM_HOOK(int, dm_op, struct domain *)
> +#endif
> +
>   XSM_HOOK(int, xen_version, uint32_t)
>   XSM_HOOK(int, domain_resource_map, struct domain *)
>   
> --- a/xen/xsm/flask/hooks.c
> +++ b/xen/xsm/flask/hooks.c
> @@ -1852,10 +1852,12 @@ static int cf_check flask_pmu_op(struct
>   }
>   #endif /* CONFIG_X86 */
>   
> +#ifdef CONFIG_IOREQ_SERVER
>   static int cf_check flask_dm_op(struct domain *d)
>   {
>       return current_has_perm(d, SECCLASS_HVM, HVM__DM);
>   }
> +#endif
>   
>   static int cf_check flask_xen_version(uint32_t op)
>   {
> 

Acked-by: Daniel P. Smith <[email protected]>